Skip to content

Add LinkerFlavor to NativeAOT #83558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 7 commits into from
Mar 22, 2023
Merged

Add LinkerFlavor to NativeAOT #83558

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fb04e3f
Prefer gold linker on linux
am11 Mar 16, 2023
3745549
Fix comment
am11 Mar 16, 2023
bef6056
Try without gc-sections
am11 Mar 17, 2023
4e6bc06
Add ability to specify linker via -p:LinkerFlavor
am11 Mar 17, 2023
0f9768f
Straighten out the spaghetti 🍝
am11 Mar 17, 2023
94a9950
Switch to gold and see what breaks
am11 Mar 17, 2023
a41d903
Set linux default to bfd
am11 Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Prefer gold linker on linux
  • Loading branch information
@am11
am11 authored Mar 16, 2023
commit fb04e3f082ea1b0354b20fcc33deff5501143416
15 changes: 15 additions & 0 deletions src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,21 @@ The .NET Foundation licenses this file to you under the MIT license.
<Error Condition="'$(_WhereLinker)' != '0' and '$(CppCompilerAndLinkerAlternative)' == '' and '$(_IsApplePlatform)' != 'true'"
Text="Requested linker ('$(CppLinker)') not found in PATH." />

<![CDATA[
Testing if gold linker is available:
! echo "" | cc -xc -fuse-ld=gold - 2>&1 | grep -qE "fuse-ld=gold|'ld'"
]]>
<Exec Command="! echo &quot;&quot; | &quot;$(CppLinker)&quot; -xc -fuse-ld=gold - 2&gt;&amp;1 | grep -qE &quot;fuse-ld=gold|'ld'&quot;"
Condition="'$(UseLlvmLinker)' != 'true' and '$(_targetOS)' == 'linux'"
IgnoreExitCode="true"
StandardOutputImportance="Low">
<Output TaskParameter="ExitCode" PropertyName="_GoldLinkerSupportedExitCode" />
</Exec>

<ItemGroup>
<LinkerArg Include="-fuse-ld=gold" Condition="'$(_GoldLinkerSupportedExitCode)' == '0'" />
</ItemGroup>

<Exec Command="command -v &quot;$(ObjCopyName)&quot;" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(_IsApplePlatform)' != 'true' and '$(StripSymbols)' == 'true'">
<Output TaskParameter="ExitCode" PropertyName="_WhereSymbolStripper" />
</Exec>
Expand Down