Skip to content

Using canonical All-pointers GC desc in more scenarios. #83800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VSadov merged 10 commits into from
Mar 23, 2023
Merged

Using canonical All-pointers GC desc in more scenarios. #83800

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b156cdb
all-pointer maps in AOT
VSadov Mar 17, 2023
4e0d3d2
a few asserts and refactorings
VSadov Mar 18, 2023
2b696d6
IsAllGCPointers
VSadov Mar 18, 2023
6c02068
optimize more cases of all-pointer GC series
VSadov Mar 19, 2023
9dde94f
Adding a test
VSadov Mar 22, 2023
3772953
undo redundant changes
VSadov Mar 23, 2023
0f71d10
make gcc happy
VSadov Mar 23, 2023
7317903
missing null check
VSadov Mar 23, 2023
9da0818
fix x86 build (more parenthesis and casting)
VSadov Mar 23, 2023
a5e0363
SkipOnMono an implementation-specific test.
VSadov Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
missing null check
  • Loading branch information
@VSadov
VSadov committed Mar 23, 2023
commit 7317903bd91fd520afc7d9853524e1070f0d61d6
3 changes: 2 additions & 1 deletion ...eclr/nativeaot/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/EETypeCreator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,8 @@ private static unsafe int GetInstanceGCDescSize(TypeBuilderState state, MethodTa
var gcBitfield = state.InstanceGCLayout;
if (isArray)
{
if (state.IsArrayOfReferenceTypes || IsAllGCPointers(gcBitfield))
if (state.IsArrayOfReferenceTypes ||
(gcBitfield != null && IsAllGCPointers(gcBitfield)))
{
// For efficiency this is special cased and encoded as one serie
return 3 * sizeof(IntPtr);
Expand Down