SPMI: Fix recGetStaticFieldCurrentClass #83843
Conversation
getStaticFieldCurrentClass has very different behavior depending on whether pIsSpeculative is passed or not, and we need to record the resulting class handle in both cases. This fixes a case of replays not working after recording that I hit while tracking down a separate issue.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsgetStaticFieldCurrentClass has very different behavior depending on whether pIsSpeculative is passed or not, and we need to record the resulting class handle in both cases. This fixes a case of replays not working after recording that I hit while tracking down a separate issue.
|
|
cc @dotnet/jit-contrib. Will wait with merging this until the weekend. |
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
It's also one of those methods that potentially can give different answers on successive calls, since it's querying the class initialization state kept by the runtime.
I assume SPMI will just overwrite and record the last answer it sees, which means the replay might not be entirely faithful and/or might not even work.
We could perhaps consider caching answers on the jit interface side -- I believe we do this for things like profile data that is also possibly volatile.
| 0x928e, | ||
| 0x4281, | ||
| {0xab, 0x68, 0xcd, 0x40, 0x17, 0xc1, 0x14, 0x1b} | ||
| constexpr GUID JITEEVersionIdentifier = { /* 95c688c7-28cf-4b1f-922a-11bf3947e56f */ |
There was a problem hiding this comment.
Side question: now that runtime and corert are in a monorepo, can we replace JITEEVersionIdentifier with computed hash without needing to hardcode in the sources?
$ git ls-files -s src/coreclr/vm/jitinterface.h | while read _ hash __; do
printf 'a "more" universal JIT interface identifier: %s' "$hash"
done
a "more" universal JIT interface identifier: cc2cccca72a0961f75ecb50fa79b07888ebec164
ghost
locked as resolved and limited conversation to collaborators
3 participants
getStaticFieldCurrentClass has very different behavior depending on whether pIsSpeculative is passed or not, and we need to record the resulting class handle in both cases.
This fixes a case of replays not working after recording that I hit while tracking down a separate issue.