Skip to content

Unroll SequenceEqual(ref byte, ref byte, nuint) in JIT #83945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 15 commits into from
Mar 29, 2023
Merged

Unroll SequenceEqual(ref byte, ref byte, nuint) in JIT #83945

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1b74d09
Unroll memcmp in lower for 1-16
EgorBo Mar 26, 2023
7354f8b
Merge branch 'main' of github.com:dotnet/runtime into unroll-memcmp
EgorBo Mar 26, 2023
81d6291
Add header
EgorBo Mar 26, 2023
1840d4d
Fix build
EgorBo Mar 26, 2023
97b0c66
Add tests
EgorBo Mar 27, 2023
229f239
Merge branch 'main' of github.com:dotnet/runtime into unroll-memcmp
EgorBo Mar 27, 2023
7bd602f
Merge branch 'main' of github.com:dotnet/runtime into unroll-memcmp
EgorBo Mar 27, 2023
dba9524
Update src/coreclr/jit/lower.cpp
EgorBo Mar 27, 2023
cbb38ee
Merge branch 'unroll-memcmp' of github.com:EgorBo/runtime-1 into unro…
EgorBo Mar 27, 2023
7ed7546
fix asserts
EgorBo Mar 27, 2023
d767076
Merge branch 'main' of github.com:dotnet/runtime into unroll-memcmp
EgorBo Mar 28, 2023
0a6f9ea
Fix asserts
EgorBo Mar 28, 2023
382866b
move IND nodes in LIR
EgorBo Mar 28, 2023
aeb8f23
Update src/coreclr/jit/lower.cpp
EgorBo Mar 28, 2023
01fd512
Update lower.cpp
EgorBo Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/coreclr/jit/lower.cpp 
Co-authored-by: Jakob Botsch Nielsen <[email protected]>
  • Loading branch information
@EgorBo @jakobbotsch
EgorBo and jakobbotsch authored Mar 28, 2023
commit aeb8f2339142dc29c75ad3aa6393d600454f271a
4 changes: 2 additions & 2 deletions src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,8 +1959,8 @@ GenTree* Lowering::LowerCallMemcmp(GenTreeCall* call)
bool lFoundUse = BlockRange().TryGetUse(lArg, &lArgUse);
bool rFoundUse = BlockRange().TryGetUse(rArg, &rArgUse);
assert(lFoundUse && rFoundUse);
GenTree* lArgClone = comp->gtNewLclLNode(lArgUse.ReplaceWithLclVar(comp), lArg->TypeGet());
GenTree* rArgClone = comp->gtNewLclLNode(rArgUse.ReplaceWithLclVar(comp), rArg->TypeGet());
GenTree* lArgClone = comp->gtNewLclvNode(lArgUse.ReplaceWithLclVar(comp), genActualType(lArg));
GenTree* rArgClone = comp->gtNewLclvNode(rArgUse.ReplaceWithLclVar(comp), genActualType(rArg));
BlockRange().InsertBefore(call, lArgClone, rArgClone);

// We're going to emit something like the following:
Expand Down