Skip to content

Improve IsKnownConstant #84002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EgorBo wants to merge 5 commits into from
Closed

Improve IsKnownConstant #84002

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2d407f
Improve IsKnownConstant
EgorBo Mar 28, 2023
f4708cd
Update lower.cpp
EgorBo Mar 28, 2023
d4bb2b3
Update src/coreclr/jit/lower.cpp
EgorBo Mar 28, 2023
a8f20d9
Merge branch 'main' of github.com:dotnet/runtime into improve-isknown…
EgorBo Mar 28, 2023
e473e6d
less conservative VN impl
EgorBo Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/coreclr/jit/lower.cpp 
Co-authored-by: SingleAccretion <[email protected]>
  • Loading branch information
@EgorBo @SingleAccretion
EgorBo and SingleAccretion authored Mar 28, 2023
commit d4bb2b3e599d1ae159333557e83e3fa4d985e1f1
8 changes: 2 additions & 6 deletions src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7797,12 +7797,8 @@ void Lowering::LowerIntrinsic(GenTreeIntrinsic* node)
// IsKnownConstant is expected to be folded in Importer/Morph/VN+ConstantProp
// This path is just in case if VN+ConstantProp didn't fold them for some reason (or e.g. they were disabled)
node->gtGetOp1()->SetUnusedValue();
LIR::Use use;
if (BlockRange().TryGetUse(node, &use))
{
use.ReplaceWith(comp->gtNewFalse());
}
BlockRange().Remove(node);
node->BashToConst(0);
return;
}
#ifdef TARGET_XARCH
ContainCheckIntrinsic(node->AsOp());
Expand Down