-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Tar: Improve unseekable stream handling #84279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carlossanlop
merged 22 commits into
dotnet:main
from
carlossanlop:TarUnseekableDataStream
Jun 1, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
295613c
Add tests that verify we handle unseekable streams correctly.
carlossanlop d627497
Add expected data field locations for all supported formats.
carlossanlop 018f709
Add exception message for when attempting to write an unseekable data…
carlossanlop 9092cb4
Add seekability validation in public TarWriter entry writing methods.
carlossanlop 6c460eb
Add TarFile stream roundtrip tests for unseekable streams.
carlossanlop 6ea8e0f
Add missing async TarFile roundtrip tests.
carlossanlop f87b9e9
Support unseekable streams in TarHeader.Write.
carlossanlop e94fefb
Reuse and simplify the code.
carlossanlop 15523ac
More reuse, remove unused and not needed.
carlossanlop 5979be9
Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
carlossanlop b702a44
Remove unnecessary resx comments.
carlossanlop 625a619
Dedicated method for writing fields to buffer depending on the format.
carlossanlop 4f702c4
Specify `Data` in name of method that expects unseekable data stream.…
carlossanlop 0054f99
Delete unnecessary method.
carlossanlop 2fc23de
Rename WritePadding to WriteEmptyPadding
carlossanlop d81b5a8
Rename test variables
carlossanlop 796d542
Merge identical test arrays into one
carlossanlop 94157b0
Invert if else to be more clear about conditions
carlossanlop 1557885
remove size assign comment
carlossanlop 943988b
Remove redundant debug assert
carlossanlop abff5c0
Async padding byte array creation simplification
carlossanlop 66dc094
Apply suggestions from code review
adamsitnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Specify
Data in name of method that expects unseekable data stream.…
… Add extra debug asserts.
- Loading branch information
commit 4f702c4625f2eaae16f38956f563d3be2879eaa1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.