Skip to content

Fix ThunkGenerator #84390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 2 commits into from
Apr 6, 2023
Merged

Fix ThunkGenerator #84390

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5790dd
Fix ThunkGenerator
MichalPetryka Apr 6, 2023
e24c735
Fix typo
MichalPetryka Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix ThunkGenerator 
Fixes:
```
 error CA1859: Change type of parameter 'tr' from 'System.IO.TextReader' to 'System.IO.StreamReader' for improved performance
 error CA1859: Change return type of method 'ParseInput' from 'System.Collections.Generic.IEnumerable<Thunkerator.FunctionDecl>' to 'System.Collections.ObjectModel.ReadOnlyCollection<Thunkerator.FunctionDecl>' for improved performance
```
  • Loading branch information
@MichalPetryka
MichalPetryka authored Apr 6, 2023
commit f5790ddf69022ec1aadd7b4f5dc1c41ac5d7aeec
3 changes: 2 additions & 1 deletion src/coreclr/tools/Common/JitInterface/ThunkGenerator/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Diagnostics;
using System.IO;
using System.Linq;
Expand Down Expand Up @@ -174,7 +175,7 @@ private enum ParseMode
IFDEFING
}

private static IEnumerable<FunctionDecl> ParseInput(TextReader tr)
private static ReadOnlyCollection<FunctionDecl> ParseInput(StreanReader tr)
{
Dictionary<string, TypeReplacement> ThunkReturnTypes = new Dictionary<string, TypeReplacement>();
Dictionary<string, TypeReplacement> ThunkTypes = new Dictionary<string, TypeReplacement>();
Expand Down