Skip to content

Split PortableThreadPool.WorkerThread start and loop body #84490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 4 commits into from
Apr 18, 2023
Merged

Split PortableThreadPool.WorkerThread start and loop body #84490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1be7d00
Split PortableThreadPool.WorkerThread start and loop body
lambdageek Apr 7, 2023
42d0d92
fix indentation
lambdageek Apr 18, 2023
b4cc691
Change loop to use return instead of break
lambdageek Apr 18, 2023
b30ca89
rename utility method to ShouldExitWorker
lambdageek Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rename utility method to ShouldExitWorker
  • Loading branch information
@lambdageek
lambdageek committed Apr 18, 2023
commit b30ca89d4ce0e07c4defeb76e9671672b9e89a50
2 changes: 1 addition & 1 deletion ...System.Private.CoreLib/src/System/Threading/PortableThreadPool.WorkerThread.NonBrowser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ private static void WorkerThreadStart()
WorkerDoWork(threadPoolInstance, ref spinWait);
}

if (WorkerTimedOutMaybeStop(threadPoolInstance, threadAdjustmentLock))
if (ShouldExitWorker(threadPoolInstance, threadAdjustmentLock))
{
break;
}
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.WorkerThread.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ private static void WorkerDoWork(PortableThreadPool threadPoolInstance, ref bool
// returns true if the worker is shutting down
// returns false if we should do another iteration
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static bool WorkerTimedOutMaybeStop (PortableThreadPool threadPoolInstance, LowLevelLock threadAdjustmentLock)
private static bool ShouldExitWorker (PortableThreadPool threadPoolInstance, LowLevelLock threadAdjustmentLock)
{
// The thread cannot exit if it has IO pending, otherwise the IO may be canceled
if (IsIOPending)
Expand Down