Fix LoadXsltTransforms and LoadAllTransforms tests in S.S.Cryptography.Xml on iOS/tvOS #84832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y.Xml on iOS/tvOS They started failing after dotnet#84426 because we now throw an exception when xslt is used. That exception gets hidden in CryptoHelpers.CreateFromName() though since you only see "Unknown transform has been encountered" so it is hard to figure out what happened. Added a more specific error message that mentions the algorithm name.
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsThey started failing after #84426 because we now throw an exception when xslt is used. That exception gets hidden in Added a more specific error message that mentions the algorithm name.
|
eerhardt
reviewed
Apr 14, 2023
...libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Reference.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Apr 14, 2023
...aries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/CryptoHelpers.cs
Show resolved
Hide resolved
eerhardt
approved these changes
Apr 14, 2023
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this up!
This was referenced Apr 14, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They started failing after #84426 because we now throw an exception when xslt is used.
That exception gets hidden in
CryptoHelpers.CreateFromName()though and you only see "Unknown transform has been encountered" so it is hard to figure out what happened.Throwing the NotSupported exception to make this easier and fixed the tests.