Skip to content

Create a createdump static library for single-file dump generation #84864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikem8361 merged 7 commits into from
May 10, 2023
Merged

Create a createdump static library for single-file dump generation #84864

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6df9b48
Create a createdump static library for single-file and native AOT dum…
Mar 9, 2023
9a464a6
Fix arm64 builds
Apr 15, 2023
b11ef58
Fix build again
Apr 15, 2023
ae4649a
Fix gcc linux x64 build
Apr 17, 2023
b1f2d13
Code review feedback changes
May 5, 2023
4a89e23
More code review feedback chantges
May 8, 2023
45ec22b
Code review feedback
May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix arm64 builds
  • Loading branch information
Mike McLaughlin committed May 9, 2023
commit 9a464a62467cdae921955cecd85954f026031582
6 changes: 0 additions & 6 deletions src/coreclr/debug/createdump/datatarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
#include "createdump.h"
#include <dbgtargetcontext.h>

#if defined(HOST_ARM64)
// Flag to check if atomics feature is available on
// the machine
bool g_arm64_atomics_present = false;
#endif

DumpDataTarget::DumpDataTarget(CrashInfo& crashInfo) :
m_ref(1),
m_crashInfo(crashInfo)
Expand Down