Skip to content

Conversation

@shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Amend the crossgen2/r2rdump for LA64.

@shushanhf
Copy link
Contributor Author

Hi, @jkotas
Could you please review this PR?
Thanks

@jkotas jkotas requested review from cshung and trylek April 23, 2023 14:43
@jkotas
Copy link
Member

jkotas commented Apr 23, 2023

Could you please review this PR?

This should be reviewed by @cshung and @trylek

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't pretend to be a loongarch calling convention expert but overall the changes look reasonable to me.

@shushanhf
Copy link
Contributor Author

shushanhf commented Apr 24, 2023

I don't pretend to be a loongarch calling convention expert but overall the changes look reasonable to me.

Thanks.
I had tested these by crossgen2 on LA64's runtime6.0.

@jkotas jkotas merged commit af1171b into dotnet:main May 17, 2023
@shushanhf shushanhf deleted the amend_crossgen2 branch May 18, 2023 00:46
@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants