Skip to content

Delete finally blocks in EcmaSignatureParser #85577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 1 commit into from
May 1, 2023
Merged

Delete finally blocks in EcmaSignatureParser #85577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 11 additions & 28 deletions src/coreclr/tools/Common/TypeSystem/Ecma/EcmaSignatureParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,19 +327,10 @@ public bool IsFieldSignature

public MethodSignature ParseMethodSignature()
{
try
{
_indexStack = new Stack<int>();
_indexStack.Push(0);
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
return ParseMethodSignatureInternal(skipEmbeddedSignatureData: false);
}
finally
{
_indexStack = null;
_embeddedSignatureDataList = null;
}

_indexStack = new Stack<int>();
_indexStack.Push(0);
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
return ParseMethodSignatureInternal(skipEmbeddedSignatureData: false);
}

private MethodSignature ParseMethodSignatureInternal(bool skipEmbeddedSignatureData)
Expand Down Expand Up @@ -463,21 +454,13 @@ public TypeDesc ParseFieldSignature()

public TypeDesc ParseFieldSignature(out EmbeddedSignatureData[] embeddedSigData)
{
try
{
_indexStack = new Stack<int>();
_indexStack.Push(1);
_indexStack.Push(0);
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
TypeDesc parsedType = ParseFieldSignature();
embeddedSigData = _embeddedSignatureDataList.Count == 0 ? null : _embeddedSignatureDataList.ToArray();
return parsedType;
}
finally
{
_indexStack = null;
_embeddedSignatureDataList = null;
}
_indexStack = new Stack<int>();
_indexStack.Push(1);
_indexStack.Push(0);
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
TypeDesc parsedType = ParseFieldSignature();
embeddedSigData = _embeddedSignatureDataList.Count == 0 ? null : _embeddedSignatureDataList.ToArray();
return parsedType;
}

public LocalVariableDefinition[] ParseLocalsSignature()
Expand Down