Skip to content

Servicing docs improvements #85731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoyosjs merged 7 commits into from
May 6, 2023
Merged

Servicing docs improvements #85731

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cb8e4fc
Servicing docs improvements
carlossanlop May 3, 2023
34c8278
Apply suggestions from code review
carlossanlop May 4, 2023
8ef6426
Apply suggestions from code review
carlossanlop May 4, 2023
5799cf0
Apply suggestions from code review
hoyosjs May 6, 2023
ca1865f
Apply suggestions from code review
hoyosjs May 6, 2023
d75b76c
Update .github/workflows/check-service-labels.yml
hoyosjs May 6, 2023
f02e0d9
Update .github/workflows/check-service-labels.yml
hoyosjs May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@hoyosjs
hoyosjs authored May 6, 2023
commit ca1865fabb25c6181696e4e2abc9ed796e714032
3 changes: 2 additions & 1 deletion docs/project/library-servicing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ For both cases, you must:
- If the fix is a test-only or infra-only change, the area owner will:
- Review the PR and sign-off if they approve it.
- Add the `Servicing-approved` label.
- The area owner can then merge the PR once the CI looks good (it's either green or the failures are investigated and determined to be unrelated to the PR).

The area owner can then merge the PR once the CI looks good (it's either green or the failures are investigated and determined to be unrelated to the PR).

**Note**: Applying the `Servicing-approved` label ensures the `check-service-labels` CI job passes, which is a mandatory requirement for merging a PR in a servicing branch.