Skip to content

Use local variable to evaluate property value only once in JsonSourceGenerator #87725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 3 commits into from
Jun 19, 2023
Merged

Use local variable to evaluate property value only once in JsonSourceGenerator #87725

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ea9801
Use temporary variable to evaluate property value only once
etemi Jun 16, 2023
463218f
Merge branch 'dotnet:main' into issue-80703
etemi Jun 17, 2023
b704edb
Add test
etemi Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use temporary variable to evaluate property value only once
  • Loading branch information
@etemi
etemi authored Jun 16, 2023
commit 0ea98011c3e2a0878a2ffc47279ab69d1c128841
13 changes: 12 additions & 1 deletion src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,18 @@ private void GenerateFastPathFuncForObject(SourceWriter writer, ContextGeneratio
? $"(({propertyGenSpec.DeclaringType.FullyQualifiedName}){ValueVarName})"
: ValueVarName;

string propValueExpr = $"{objectExpr}.{propertyGenSpec.NameSpecifiedInSourceCode}";
string propValueExpr;
if (defaultCheckType != DefaultCheckType.None)
{
// Use temporary variable to evaluate property value only once
string localVariableName = $"__value_{propertyGenSpec.NameSpecifiedInSourceCode}";
writer.WriteLine($"{propertyGenSpec.PropertyType.FullyQualifiedName} {localVariableName} = {objectExpr}.{propertyGenSpec.NameSpecifiedInSourceCode};");
propValueExpr = localVariableName;
}
else
{
propValueExpr = $"{objectExpr}.{propertyGenSpec.NameSpecifiedInSourceCode}";
}

switch (defaultCheckType)
{
Expand Down