Skip to content

Fix Unnecessary sign-extension for (nuint)span.Length #88136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 19 commits into from
Oct 10, 2023
Merged

Fix Unnecessary sign-extension for (nuint)span.Length #88136

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f403ba2
unconditionally set isNeverNegative in morph, use that data when opti…
En3Tho Jun 28, 2023
d3e96b8
cr, change condition and apply optimization to winX64 only
En3Tho Jun 29, 2023
0bfe3cd
apply suggestions and add lclfld check too
En3Tho Jun 30, 2023
914da44
Run jit-format
En3Tho Jun 30, 2023
e73dd3e
ADDED CORINFO_FLG_SPAN
En3Tho Jul 4, 2023
d6652bc
Address CR
En3Tho Jul 4, 2023
2dc4601
Pull main and resolve conflicts
En3Tho Jul 4, 2023
bfb1395
Redo CR fix after pull main.
En3Tho Jul 4, 2023
5edb8c9
Merge branch 'main' of https://github.com/dotnet/runtime into issue-8…
En3Tho Aug 8, 2023
cdb554f
merge pull main & removed corinfo flag. A quick check if these change…
En3Tho Aug 14, 2023
0a62f7a
fix build for ee
En3Tho Aug 14, 2023
52021c3
missed this one
En3Tho Aug 14, 2023
d665ba5
marked span & readonlyspan as intrinsics, handled checking
En3Tho Aug 14, 2023
7a6d356
CR: removed IsSpan from GenTreeLclVar and used proposed change in Pro…
En3Tho Sep 29, 2023
1f0431a
CR: forgot to remove redundant SetIsSpan(true) call. Fixed
En3Tho Oct 1, 2023
eadf5fe
restored some lclmorph lines to keep diff simpler
En3Tho Oct 1, 2023
5b0b0df
It seems like it affects something after all?
En3Tho Oct 3, 2023
6ce32b2
Optimize spans only when Optimizations are enabled
En3Tho Oct 9, 2023
8e82297
revert OptimizationEnabled check
En3Tho Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build for ee
  • Loading branch information
@En3Tho
En3Tho committed Aug 14, 2023
commit 0a62f7ad3dec3feef938aa8f84fece3cb2b0f3bc
5 changes: 0 additions & 5 deletions src/coreclr/vm/jitinterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3927,13 +3927,8 @@ uint32_t CEEInfo::getClassAttribsInternal (CORINFO_CLASS_HANDLE clsHnd)
ret |= CORINFO_FLG_VALUECLASS;

if (pMT->IsByRefLike())
{
ret |= CORINFO_FLG_BYREF_LIKE;

if (pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__SPAN)) || pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__READONLY_SPAN)))
ret |= CORINFO_FLG_SPAN;
}

if (pClass->IsUnsafeValueClass())
ret |= CORINFO_FLG_UNSAFE_VALUECLASS;
}
Expand Down