Skip to content

Add SocketsHttpHandler connection metrics #88893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 4 commits into from
Jul 14, 2023
Merged

Add SocketsHttpHandler connection metrics #88893

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67c9310
Add SocketsHttpHandler connection metrics
MihaZupan Jul 14, 2023
0d5415e
PR feedback
MihaZupan Jul 14, 2023
e5b0b21
Improve assert around _originAuthority
MihaZupan Jul 14, 2023
6ed05b7
Typo
MihaZupan Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Typo
  • Loading branch information
@MihaZupan
MihaZupan committed Jul 14, 2023
commit 6ed05b708fd27c3545d479167b54aed554317064
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public HttpConnectionPool(HttpConnectionPoolManager poolManager, HttpConnectionK
_proxyUri = proxyUri;
_maxHttp11Connections = Settings._maxConnectionsPerServer;

// The only case where 'host' will not be set if this is a Proxy connection pool.
// The only case where 'host' will not be set is if this is a Proxy connection pool.
Debug.Assert(host is not null || (kind == HttpConnectionKind.Proxy && proxyUri is not null));
_originAuthority = new HttpAuthority(host ?? proxyUri!.IdnHost, port);

Expand Down