Skip to content

Fix outerloop tests in System.Formats.Tar #89172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 1 commit into from
Jul 19, 2023
Merged

Fix outerloop tests in System.Formats.Tar #89172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix outerloop tests in System.Formats.Tar 
The change from #88280 caused an issue when discovering the test:

```
System.InvalidOperationException : An appropriate member 'ManualTestsEnabled' could not be found. The conditional method needs to be a static method, property, or field on the type System.Formats.Tar.Tests.ManualTestsAsync or any ancestor, of any visibility, accepting zero arguments, and having a return type of Boolean.
```
  • Loading branch information
@akoeplinger
akoeplinger authored Jul 19, 2023
commit eeb540ee305d352c0d0fdaa7d4f1fd93437b10ae
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public static IEnumerable<object[]> WriteEntry_LongFileSize_TheoryDataAsync()
// Fixes error xUnit1015: MemberData needs to be in the same class
=> ManualTests.WriteEntry_LongFileSize_TheoryData();

[ConditionalTheory(nameof(ManualTests.ManualTestsEnabled))]
[ConditionalTheory(typeof(ManualTests), nameof(ManualTests.ManualTestsEnabled))]
[MemberData(nameof(WriteEntry_LongFileSize_TheoryDataAsync))]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.Android | TestPlatforms.Browser, "Needs too much disk space.")]
public async Task WriteEntry_LongFileSizeAsync(TarEntryFormat entryFormat, long size, bool unseekableStream)
Expand Down