Improve enum parsing in config binder generator #89823
Conversation
ghost
added
area-Extensions-Configuration
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #88873
|
layomia
left a comment
layomia
left a comment
There was a problem hiding this comment.
LGTM, thanks @pedrobsaila! Pls address these comments in a follow up PR if you get a chance.
| EmitBlankLineIfRequired(); | ||
| EmitPrimitiveParseMethod(type); | ||
|
|
||
| if (type.StringParsableTypeKind == StringParsableTypeKind.Enum) |
There was a problem hiding this comment.
I think the parser should not include enum types in the PrimitivesForHelperGen list. The emitter should have minimal/no post-processing of the input data. The SourceGenerationSpec could have a boolean property indicating whether an enum was part of the input graph.
...libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/CoreBindingHelper.cs
Show resolved
Hide resolved
| parsedValueExpr = $"({typeDisplayString}){Identifier.Enum}.{Identifier.Parse}(typeof({typeDisplayString}), {Identifier.value}, ignoreCase: true)"; | ||
| } | ||
| break; | ||
| return; |
There was a problem hiding this comment.
We should never fall into this case based on other diffs above.
|
Created #89936 to track the follow-up fixes. |
5 participants
Fixes #88873