Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
dc67073
Bump main version to 9.0-alpha1
carlossanlop Aug 15, 2023
4137b9c
Try bumping SdkBandVersion
lewing Aug 15, 2023
596c541
Bump the emscripten transport package
lewing Aug 15, 2023
0ff0b4b
Fix typo
lewing Aug 15, 2023
9f1049a
Update TFM to net9.0, minimum to net8.0, use RC1 nightly for SDK to a…
jkoritzinsky Aug 16, 2023
eb1aeb7
Add compat suppressions for removed EOL TFM assets that will not be i…
jkoritzinsky Aug 16, 2023
9a3a1ef
PR feedback
jkoritzinsky Aug 16, 2023
883d3ee
Fix ILLink errors in the build.
jkoritzinsky Aug 16, 2023
353edb3
Update Versions.props
lewing Aug 16, 2023
f7f79b8
PR feedback
jkoritzinsky Aug 17, 2023
3bb117a
Don't use non-portable rids in src/tests infra
jkoritzinsky Aug 17, 2023
466567e
Merge branch 'main' of github.com:dotnet/runtime into BumpMainTo90Alpha1
jkoritzinsky Aug 17, 2023
5e8ebc1
Fix restore for Microsoft.NETCore.App.Runtime-based sfxprojs
jkoritzinsky Aug 17, 2023
6acc9bd
Fix libs build and expand where we set RunAnalyzers
jkoritzinsky Aug 17, 2023
1a14a2f
PR feedback
jkoritzinsky Aug 18, 2023
72560ed
Try fixing the package testing.
jkoritzinsky Aug 18, 2023
a1c09bf
Fix remaining restore issues.
jkoritzinsky Aug 18, 2023
6ebdb85
Patch preserialized resources to account for the major version bump (…
jkoritzinsky Aug 18, 2023
80d989e
Remove explicit hard-coding of net6.0 package testing
jkoritzinsky Aug 18, 2023
138b36a
Convert more references to net8.0 to net9.0
jkoritzinsky Aug 18, 2023
f683241
Merge branch 'main' into BumpMainTo90Alpha1
lewing Aug 21, 2023
3d0d643
Revert TFM changes
jkoritzinsky Aug 21, 2023
4e6167a
Add workaround for RequiresPreviewFeatures and regenerate SLE compat …
jkoritzinsky Aug 21, 2023
be2c615
[wasm] Unpin sdk version, and change channel to 9.0 for WBT
radical Aug 21, 2023
9445038
Revert "[wasm] Unpin sdk version, and change channel to 9.0 for WBT"
jkoritzinsky Aug 21, 2023
50f3771
Patch preserialized resources to account for the major version bump (…
jkoritzinsky Aug 18, 2023
3413966
Suppress EventLog package validation failures to get allconfiguration…
jkoritzinsky Aug 21, 2023
30f1200
Fix queue count in rate limiters (#90810)
BrennanConroy Aug 21, 2023
2721f80
Adding PACKAGE.md to System.Runtime.Caching package (#90701)
HongGit Aug 21, 2023
dbcf346
[wasm] Unpin sdk version, and change channel to 9.0 for WBT
radical Aug 21, 2023
2b4705f
workloads-testing.targets: Ignore standard error/warning formats
radical Aug 22, 2023
60366ef
Force AssemblyVersion
jkoritzinsky Aug 22, 2023
6717aa8
Revert changes.
jkoritzinsky Aug 22, 2023
26eb430
Remove the SLE suppressions again.
jkoritzinsky Aug 22, 2023
578df91
Fix 9.0->8.0 replace
jkoritzinsky Aug 22, 2023
92785ac
Revert "Fix queue count in rate limiters (#90810)"
jkoritzinsky Aug 22, 2023
00ba089
Fix formatting
jkoritzinsky Aug 22, 2023
23468ad
Update Version.Details.xml for xlifftasks to try to fix prebuilt error.
jkoritzinsky Aug 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ILLink errors in the build.
  • Loading branch information
jkoritzinsky committed Aug 16, 2023
commit 883d3ee72fb9a14782a666e51bc678bb307de6e6
2 changes: 2 additions & 0 deletions src/coreclr/crossgen-corelib.proj
Original file line number Diff line number Diff line change
Expand Up @@ -158,4 +158,6 @@
<Message Importance="High" Text="Crossgenning of System.Private.CoreLib succeeded." />
<Message Importance="High" Text="Product binaries are available at $(BinDir)" />
</Target>

<Import Project="$(RepositoryEngineeringDir)targetingpacks.targets" />
</Project>
1 change: 1 addition & 0 deletions src/coreclr/runtime-prereqs.proj
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<VerifySourceLinkFileExists>false</VerifySourceLinkFileExists>
<VerifySourceLinkFileExists Condition="'$(ContinuousIntegrationBuild)' == 'true' AND '$(EnableSourceControlManagerQueries)' == 'true'">true</VerifySourceLinkFileExists>
<AssemblyName>.NET Runtime</AssemblyName>
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>

<Import Project="$(RepositoryEngineeringDir)versioning.targets" />
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/runtime.proj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<_BuildNativeTargetOS>$(TargetOS)</_BuildNativeTargetOS>
<_BuildNativeTargetOS Condition="'$(TargetsLinuxBionic)' == 'true'">linux-bionic</_BuildNativeTargetOS>
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ protected override object CreateObject(IntPtr externalComObject, CreateObjectFla
Debug.Assert(flags == CreateObjectFlags.UniqueInstance);

var iid = ICLRMetaHost.IID;
if (Marshal.QueryInterface(externalComObject, ref iid, out IntPtr hostPtr) != 0)
if (Marshal.QueryInterface(externalComObject, in iid, out IntPtr hostPtr) != 0)
{
throw new ArgumentException("Expected ICLRMetaHost COM interface");
}
Expand Down Expand Up @@ -284,7 +284,7 @@ private CoCreateWrapperCache() { }
Debug.Assert(flags == CreateObjectFlags.UniqueInstance);

var iid = new Guid("AA544D42-28CB-11d3-BD22-0000F80849BD");
if (Marshal.QueryInterface(externalComObject, ref iid, out IntPtr ppv) != 0)
if (Marshal.QueryInterface(externalComObject, in iid, out IntPtr ppv) != 0)
{
return null;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@
<OutputPath>$(RuntimeBinDir)/ilc-published/netstandard</OutputPath>
<Configurations>Debug;Release;Checked</Configurations>
<PlatformTarget>AnyCPU</PlatformTarget>
<!--
The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
-->
<IsTrimmable>false</IsTrimmable>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So netstandard2.0 doesn't support trimming, at all? If so, should we set this globally in a targets file based on the TFM?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we don't have trimming support for .NET Standard 2.0 (it's completely unannotated, so we can't have accurate analysis).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then shouldn't we disable this globally in a targets file for all projects?

</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkVersion)" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCoreVersion)" />
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@
<Platforms>AnyCPU;x64</Platforms>
<PlatformTarget>AnyCPU</PlatformTarget>
<RunAnalyzers>false</RunAnalyzers>
<!--
The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
-->
<IsTrimmable>false</IsTrimmable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/native/corehost/corehost.proj
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<!-- Global location for version files -->
<NativeVersionFile Condition="$([MSBuild]::IsOsPlatform(Windows))">$(ArtifactsObjDir)_version.h</NativeVersionFile>
<NativeVersionFile Condition="!$([MSBuild]::IsOsPlatform(Windows))">$(ArtifactsObjDir)_version.c</NativeVersionFile>
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading