Skip to content

[RISC-V] ELT Profiler Bring-Up #91313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 12 commits into from
Sep 5, 2023
Merged

[RISC-V] ELT Profiler Bring-Up #91313

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e76256b
[RISC-V] Generate profiling function callbacks
tomeksowi Aug 22, 2023
32f5714
[RISC-V] Fix asm stub for calling profiler callbacks
tomeksowi Aug 22, 2023
91e9bf1
[RISC-V] Pass arguments for Profile(Enter|Leave|Tailcall)Naked stubs …
tomeksowi Aug 24, 2023
2b0d171
[RISC-V] Remove unimplemented definition of EmitRet
tomeksowi Aug 25, 2023
b38930c
[RISC-V] Copy struct from registers into a buffer so that profiler ca…
tomeksowi Aug 28, 2023
9ca5447
[RISC-V] Implement ProfileArgIterator::GetReturnBufferAddr()
tomeksowi Aug 29, 2023
56a9863
Factor out duplicated test results checking routine in SlowPathELTPro…
tomeksowi Aug 29, 2023
90c6b3a
[RISC-V] Clean up PROFILE_PLATFORM_SPECIFIC_DATA
tomeksowi Aug 29, 2023
e33d81e
[RISC-V] Remove commented out code
tomeksowi Aug 30, 2023
c94bae2
[RISC-V] Fix formatting
tomeksowi Aug 30, 2023
fb982b5
[RISC-V] Apply format patch from failed check
tomeksowi Aug 30, 2023
1f46d7c
[RISC-V] Post-review fixes
tomeksowi Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[RISC-V] Apply format patch from failed check
  • Loading branch information
@tomeksowi
tomeksowi committed Aug 30, 2023
commit fb982b58c781754cc4919edaf8de5e4bb5e230a9
46 changes: 23 additions & 23 deletions src/coreclr/jit/codegenriscv64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,9 +894,9 @@ void CodeGen::genFnEpilog(BasicBlock* block)
#if !FEATURE_FASTTAILCALL
noway_assert(jmpNode->gtOper == GT_JMP);
#else // FEATURE_FASTTAILCALL
// armarch
// If jmpNode is GT_JMP then gtNext must be null.
// If jmpNode is a fast tail call, gtNext need not be null since it could have embedded stmts.
// armarch
// If jmpNode is GT_JMP then gtNext must be null.
// If jmpNode is a fast tail call, gtNext need not be null since it could have embedded stmts.
noway_assert((jmpNode->gtOper != GT_JMP) || (jmpNode->gtNext == nullptr));

// Could either be a "jmp method" or "fast tail call" implemented as epilog+jmp
Expand Down Expand Up @@ -1212,9 +1212,9 @@ void CodeGen::genEHCatchRet(BasicBlock* block)
}

// move an immediate value into an integer register
void CodeGen::instGen_Set_Reg_To_Imm(emitAttr size,
regNumber reg,
ssize_t imm,
void CodeGen::instGen_Set_Reg_To_Imm(emitAttr size,
regNumber reg,
ssize_t imm,
insFlags flags DEBUGARG(size_t targetHandle) DEBUGARG(GenTreeFlags gtFlags))
{
emitter* emit = GetEmitter();
Expand Down Expand Up @@ -3011,7 +3011,7 @@ void CodeGen::genCodeForReturnTrap(GenTreeOp* tree)
callTarget, /* ireg */
REG_NA, 0, 0, /* xreg, xmul, disp */
false /* isJump */
);
);

regMaskTP killMask = compiler->compHelperCallKillSet(CORINFO_HELP_STOP_FOR_GC);
regSet.verifyRegistersUsed(killMask);
Expand Down Expand Up @@ -4006,7 +4006,7 @@ void CodeGen::genEmitHelperCall(unsigned helper, int argSize, emitAttr retSize,
callTarget, /* ireg */
REG_NA, 0, 0, /* xreg, xmul, disp */
false /* isJump */
);
);

regMaskTP killMask = compiler->compHelperCallKillSet((CorInfoHelpFunc)helper);
regSet.verifyRegistersUsed(killMask);
Expand Down Expand Up @@ -6346,19 +6346,19 @@ void CodeGen::genCallInstruction(GenTreeCall* call)
else
#endif // FEATURE_READYTORUN
if (call->gtCallType == CT_HELPER)
{
CorInfoHelpFunc helperNum = compiler->eeGetHelperNum(methHnd);
noway_assert(helperNum != CORINFO_HELP_UNDEF);
{
CorInfoHelpFunc helperNum = compiler->eeGetHelperNum(methHnd);
noway_assert(helperNum != CORINFO_HELP_UNDEF);

void* pAddr = nullptr;
addr = compiler->compGetHelperFtn(helperNum, (void**)&pAddr);
assert(pAddr == nullptr);
}
else
{
// Direct call to a non-virtual user function.
addr = call->gtDirectCallAddress;
}
void* pAddr = nullptr;
addr = compiler->compGetHelperFtn(helperNum, (void**)&pAddr);
assert(pAddr == nullptr);
}
else
{
// Direct call to a non-virtual user function.
addr = call->gtDirectCallAddress;
}

assert(addr != nullptr);

Expand Down Expand Up @@ -6785,8 +6785,8 @@ void CodeGen::genFloatToFloatCast(GenTree* treeNode)
//------------------------------------------------------------------------
// genCreateAndStoreGCInfo: Create and record GC Info for the function.
//
void CodeGen::genCreateAndStoreGCInfo(unsigned codeSize,
unsigned prologSize,
void CodeGen::genCreateAndStoreGCInfo(unsigned codeSize,
unsigned prologSize,
unsigned epilogSize DEBUGARG(void* codePtr))
{
IAllocator* allowZeroAlloc = new (compiler, CMK_GC) CompIAllocator(compiler->getAllocatorGC());
Expand Down Expand Up @@ -7131,7 +7131,7 @@ inline void CodeGen::genJumpToThrowHlpBlk_la(
callTarget, /* ireg */
REG_NA, 0, 0, /* xreg, xmul, disp */
false /* isJump */
);
);

regMaskTP killMask = compiler->compHelperCallKillSet((CorInfoHelpFunc)(compiler->acdHelper(codeKind)));
regSet.verifyRegistersUsed(killMask);
Expand Down