[release/8.0] Fix crash when calling AssemblyLoadContext.Unload twice #91346
Conversation
The AssemblyLoadContext.InitiateUnload method was not handling multiple calls correctly. Instead of making the extra calls dummy, it was calling the native runtime helper again. This change fixes it by simply ensuring that the runtime helper is called just once.
janvorli
added
Servicing-consider
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #91283 to release/8.0 /cc @janvorli Customer ImpactWhen a customer code calls the TestingDirected test for the issue, libraries tests, coreclr tests, CI testing RiskLow, the change just ensures that the call to the underlying native runtime helper method is made only once.
|
|
@jkotas can you please give a code review sign-off? |
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. once ready this can be merged.
jeffschwMSFT
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Backport of #91283 to release/8.0
/cc @janvorli
Customer Impact
When a customer code calls the
AssemblyLoadContext.Unloadmethod twice, runtime crashes with a FailFast. Only the first call to theUnloadmethod should have any effect, further calls to it should be a no-op.Testing
Directed test for the issue, libraries tests, coreclr tests, CI testing
Risk
Low, the change just ensures that the call to the underlying native runtime helper method is made only once.