Enable analyzer analyzers #91733
Merged
Enable analyzer analyzers #91733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Microsoft.CodeAnalysis.Analyzer in our builds, to help validate our analyzers and source generators. A few projects were doing this explicitly; this does it for all.
stephentoub
requested review from
lewing,
marek-safar,
pavelsavara and
sbomer
as code owners
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsUse Microsoft.CodeAnalysis.Analyzer in our builds, to help validate our analyzers and source generators. A few projects were doing this explicitly; this does it for all. Note that for Environment.NewLine, there's a debate happening about it in dotnet/roslyn-analyzers#6467. I chose to silence the warnings by making tweaks to the code that don't actually impact what's generated but that make the use of the banned symbol go away.
|
This was referenced Sep 7, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Microsoft.CodeAnalysis.Analyzer in our builds, to help validate our analyzers and source generators. A few projects were doing this explicitly; this does it for all.
Note that for Environment.NewLine, there's a debate happening about it in dotnet/roslyn-analyzers#6467. I chose to silence the warnings by making tweaks to the code that don't actually impact what's generated but that make the use of the banned symbol go away.