Skip to content

Conversation

@radekdoulik
Copy link
Member

This measures the time of OnAfterRender event on index page, to mimic the blazor benchmark's First UI measurement.

Also

  • fix blazor frame url base

  • let simple-server handle non-root urls with trailing '/'

This measures the time of `OnAfterRender` event on index page,
to mimic the blazor benchmark's `First UI` measurement.

Also

 * fix blazor frame url base

 * let simple-server handle non-root urls with trailing '/'
@ghost
Copy link

ghost commented Sep 7, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This measures the time of OnAfterRender event on index page, to mimic the blazor benchmark's First UI measurement.

Also

  • fix blazor frame url base

  • let simple-server handle non-root urls with trailing '/'

Author: radekdoulik
Assignees: radekdoulik
Labels:

area-Infrastructure-mono, area-System.Runtime.InteropServices.JavaScript

Milestone: -

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
<title>blazor</title>
<!-- <base href="/blazor-template/" /> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what's the reason for this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Index.razor page wasn't loading properly, so I changed it according to https://learn.microsoft.com/en-us/aspnet/core/blazor/host-and-deploy/?view=aspnetcore-8.0&tabs=visual-studio#app-base-path

Interestingly I had to also change the blazor.webassembly.js path to make it work.

@lewing lewing merged commit e488d06 into dotnet:main Sep 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants