[RISC-V] ELT profiler: fix reconstruction of struct args passed partially on the stack #91797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-Diagnostics-coreclr
community-contribution
|
Tagging subscribers to this area: @tommcdon Issue DetailsThe fix is similar to what ShuffleIterator is doing, i.e. if Part of #84834
|
Member
Author
davmason
approved these changes
Sep 8, 2023
Contributor
davmason
left a comment
davmason
left a comment
There was a problem hiding this comment.
Profiler test changes LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is similar to what ShuffleIterator is doing, i.e. if
ArgIteratorreturns a general register offset that can't fitargSize, this means the other part of the struct was spilled on the stack.Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @clamp03 @sirntar @yurai007