Minimize net diff of binder-gen visibility/identifier-clash fix #91974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
tarekgh
reviewed
Sep 13, 2023
tarekgh
approved these changes
Sep 13, 2023
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
LGTM. will be good to wait @eiriktsarpalis to look at the change in the json source gen.
Contributor
Author
|
Following offline discussion with @eiriktsarpalis, I've addressed his last concern regarding using the built-in API for accessibility checks. 3b82834 |
layomia
commented
Sep 13, 2023
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Specs/KnownTypeSymbols.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #91657. Primarily reverts JSON changes made in that PR.
#91967 shows the overall diff of the bug fix and addresses feedback to switch to use the Roslyn API for accessibility checks.