Skip to content

Conversation

@JongHeonChoi
Copy link
Contributor

@JongHeonChoi JongHeonChoi commented Sep 20, 2023

We changed the casing from Riscv to RiscV since the V component is a different pronounced word.
#73437 (comment)

cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @clamp03 @sirntar @yurai007

@ghost ghost added area-VM-coreclr community-contribution Indicates that the PR has been added by a community member labels Sep 20, 2023
@jkotas jkotas added the arch-riscv Related to the RISC-V architecture label Sep 20, 2023
@jkotas jkotas requested review from clamp03 and gbalykov September 20, 2023 15:24
#elif defined(TARGET_RISCV64)

// See unwindRiscv64.cpp
// See unwindRiscV64.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual filename is unwindriscv64.cpp, I think it's better to change it here to lowercase too for consistency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed it.

Copy link
Member

@clamp03 clamp03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you.

Copy link
Member

@gbalykov gbalykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wscho77 wscho77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 96f48b7 into dotnet:main Sep 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-riscv Related to the RISC-V architecture area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants