[Mono]: Add missing case for constrained gsharedvt call. #92338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lateralusX
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
ghost
added
the
needs-area-label
lateralusX
added
area-Codegen-AOT-mono
and removed
needs-area-label
dotnet@1b788f4 added a new value to our MonoRgctxInfoType enum type, but appears that all cases where not full adjusted. Running System.Buffers tests in full AOT hits the assert in info_equal about missing case, https://github.com/dotnet/runtime/blob/0dc5903679606b072adac70a268cdb77d1147b3e/src/mono/mono/mini/mini-generic-sharing.c#L2908. This commit adds the new enum value and align handling similar to other cases added by that commit.
lateralusX
force-pushed
the
lateralusX/fix-missing-gsharedvt-constrained-call-case
branch
from
fda4418 to
1a6f419
Compare
lambdageek
approved these changes
Sep 20, 2023
Member
|
we should backport to net8.0 |
vargaz
approved these changes
Sep 20, 2023
This was referenced Sep 20, 2023
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6250778309 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b788f4 added a new value to our MonoRgctxInfoType enum type, but appears that all cases where not full adjusted. Running System.Buffers tests in full AOT hits the assert in
info_equalabout missing case,runtime/src/mono/mono/mini/mini-generic-sharing.c
Line 2908 in 0dc5903
This commit adds the new enum value and align handling similar to other cases added by that commit. After the fix System.Buffers test pass using full AOT.