Skip to content

Do not call SignalSession on invalid session IDs #92431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davmason merged 2 commits into from
Sep 22, 2023
Merged

Do not call SignalSession on invalid session IDs #92431

davmason merged 2 commits into from
Sep 22, 2023

Conversation

@davmason
Copy link
Contributor

@davmason davmason commented Sep 21, 2023

Fixes #92098
Fixes #92236

@davmason davmason added this to the 9.0.0 milestone Sep 21, 2023
@davmason davmason requested review from a team and lateralusX September 21, 2023 19:42
@davmason davmason self-assigned this Sep 21, 2023
@ghost
Copy link

ghost commented Sep 21, 2023

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #92098
Fixes #92236

Author: davmason
Assignees: davmason
Labels:

area-System.Diagnostics.Tracing
Milestone: 9.0.0

@davmason davmason mentioned this pull request Sep 21, 2023
Closed
@davmason
Copy link
Contributor Author

davmason commented Sep 21, 2023

/backport to release/8.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Started backporting to release/8.0-rc2: https://github.com/dotnet/runtime/actions/runs/6268145663

@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
lateralusX
lateralusX reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@lateralusX lateralusX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should close the potential race between EventPipeInternal.SignalSession(m_sessionID) and EventPipeInternal.Disable(sessionID) by grabbing m_dispatchControllLock around call to EventPipeInternal.Disable(sessionID).

@build-analysis build-analysis bot mentioned this pull request Sep 22, 2023
Closed
@davmason davmason merged commit d59a99e into dotnet:main Sep 22, 2023
@davmason davmason mentioned this pull request Sep 26, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lateralusX lateralusX lateralusX left review comments

@tommcdon tommcdon tommcdon approved these changes

Assignees

@davmason davmason

Labels

area-System.Diagnostics.Tracing

Projects

None yet

Milestone

9.0.0

3 participants

@davmason @lateralusX @tommcdon