Skip to content

Extend preinitialization interpreter #92470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 4 commits into from
Sep 27, 2023
Merged

Extend preinitialization interpreter #92470

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09ef1ca
Extend preinitialization interpreter
MichalStrehovsky Sep 22, 2023
0a9c208
More tests
MichalStrehovsky Sep 23, 2023
16f724f
Remove hack
MichalStrehovsky Sep 23, 2023
f55fb70
FB
MichalStrehovsky Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove hack
  • Loading branch information
@MichalStrehovsky
MichalStrehovsky committed Sep 23, 2023
commit 16f724fef434fb55ebcb604959c8a10c3696a5f6
9 changes: 1 addition & 8 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ private Status TryScanMethod(MethodIL methodIL, Value[] parameters, Stack<Method
}

Value retVal;
if ((!method.IsIntrinsic && !method.OwningType.IsIntrinsic) || !TryHandleIntrinsicCall(method, methodParams, out retVal))
if (!method.IsIntrinsic || !TryHandleIntrinsicCall(method, methodParams, out retVal))
{
recursionProtect ??= new Stack<MethodDesc>();
recursionProtect.Push(methodIL.OwningMethod);
Expand Down Expand Up @@ -1701,13 +1701,6 @@ private bool TryHandleIntrinsicCall(MethodDesc method, Value[] parameters, out V
retVal = ValueTypeValue.FromSByte(parameters[0] == parameters[1] ? (sbyte)1 : (sbyte)0);
return true;
}
case "get_IsSupported" when method.OwningType is MetadataType sse2Type
&& sse2Type.Name == "Sse2":
{
// TODO: hacky
retVal = ValueTypeValue.FromSByte(sse2Type.Context.Target.Architecture == TargetArchitecture.X64 ? (sbyte)1 : (sbyte)0);
return true;
}
}

return false;
Expand Down