IndentedTextWriter doesn't use indentation on the first line #92791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.CodeDom
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-codedom Issue DetailsFixes #92039
|
buyaa-n
approved these changes
Oct 4, 2023
Contributor
buyaa-n
left a comment
buyaa-n
left a comment
There was a problem hiding this comment.
LGTM, thank you @pedrobsaila
Contributor
|
This bug fix is somewhat breaking, though not sure if we want to add breaking change doc. The indentation issue first reported in #30351 where it is mentioned that we would like to accept fix even if it was breaking. The issue is resolved with #46436 but it only fixed the async Write indentation part. We did not add a breaking change doc for that fix, but this one might be more breaking. Please let me know what you think @ericstj @jeffhandley @steveharter |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92039