Replace CMake Object Interfaces with CMake 3.20 Objects #92966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regular objects, as with CMake 3.20, we no longer need to go through the full interfaces path.
ghost
assigned
|
Tagging subscribers to this area: @hoyosjs Issue DetailsResolves #92787. Now that we have set 3.20 as the minimum version of CMake in the repo, we no longer need to separate
|
Contributor
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
The CG2 failures in the outerloop are unrelated. I'll take a look separately. |
jkoritzinsky
approved these changes
Oct 3, 2023
Contributor
Author
|
Merging this now since failures are unrelated and are being addressed in another PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #92787. Now that we have set 3.20 as the minimum version of CMake in the repo, we no longer need to separate
OBJECTandINTERFACEtargets in the CMakeLists.txt files. This PR removes saidINTERFACEtargets, and adjusts theOBJECTones accordingly, in order to take advantage of 3.20's ability to link directly to object libraries withtarget_link_libraries().