Skip to content

Don't widen to Int128 in CastCache #92984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 2 commits into from
Oct 5, 2023
Merged

Don't widen to Int128 in CastCache #92984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94a1338
Don't widen to Int128 in CastCache
MichalStrehovsky Oct 4, 2023
0a72852
FB
MichalStrehovsky Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/CastCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ internal static CastResult TryGet(int[] table, nuint source, nuint target)
TableMask(ref tableData) = size - 1;

// Fibonacci hash reduces the value into desired range by shifting right by the number of leading zeroes in 'size-1'
byte shift = (byte)BitOperations.LeadingZeroCount(size - 1);
byte shift = (byte)BitOperations.LeadingZeroCount((nuint)(size - 1));
HashShift(ref tableData) = shift;

return table;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/GenericCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ internal bool TryGet(TKey key, out TValue? value)
ref Entry tableData = ref TableData(table);

// Fibonacci hash reduces the value into desired range by shifting right by the number of leading zeroes in 'size-1'
byte shift = (byte)BitOperations.LeadingZeroCount(size - 1);
byte shift = (byte)BitOperations.LeadingZeroCount((nuint)(size - 1));
HashShift(table) = shift;

return table;
Expand Down