Split the MarshalAsParser into two classes #93038
Conversation
One class will handle the raw parsing of the MarshalAs attribute. The other class handles resolving a MarshalAs attribute into the custom marshaller type that will provide the marshalling based on our generator's rules. This split makes it easier for other generator models to reuse our parsing logic without having to also reuse our custom marshaller resolution logic. In particular, a hypothetical IDispatch-focused generator would want to marshal all values into `VARIANT` values, so they may want to reuse the marshaller attribute parsing logic, but not the custom marshallers directly.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
ghost
assigned
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsOne class will handle the raw parsing of the MarshalAs attribute. The other class handles resolving a MarshalAs attribute into the custom marshaller type that will provide the marshalling based on our generator's rules. This split makes it easier for other generator models to reuse our parsing logic without having to also reuse our custom marshaller resolution logic. In particular, a hypothetical IDispatch-focused generator would want to marshal all values into
|
| /// This class suppports parsing a System.Runtime.InteropServices.MarshalAsAttribute. | ||
| /// This class suppports parsing a System.Runtime.InteropServices.MarshalAsAttribute into a <see cref="MarshalAsInfo"/>. | ||
| /// </summary> | ||
| public sealed class MarshalAsAttributeParser : IMarshallingInfoAttributeParser, IUseSiteAttributeParser |
There was a problem hiding this comment.
Is this still used as a IMarshallingInfoAttributeParser now?
There was a problem hiding this comment.
It's intended to optionally be used that way. We don't use it in the same way currently, but we delegate to this implementation from the other one through the interface.
2 participants
One class will handle the raw parsing of the MarshalAs attribute.
The other class handles resolving a MarshalAs attribute into the custom marshaller type that will provide the marshalling based on our generator's rules.
This split makes it easier for other generator models to reuse our parsing logic without having to also reuse our custom marshaller resolution logic. In particular, a hypothetical IDispatch-focused generator would want to marshal all values into
VARIANTvalues, so they may want to reuse the marshaller attribute parsing logic, but not the custom marshallers directly.