Skip to content

[wasm][debugger] Add tests for all possible types of negative arguments #93058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilonatommy merged 7 commits into from
Oct 12, 2023
Merged

[wasm][debugger] Add tests for all possible types of negative arguments #93058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e5cc20
Add tests with clean-up.
ilonatommy Oct 5, 2023
d77dc15
Expected value update: the behavior of doubles was correct.
ilonatommy Oct 5, 2023
d102360
Short cannot be tested the same way as other types.
ilonatommy Oct 5, 2023
5db6d14
Typo
ilonatommy Oct 5, 2023
f2afb63
Lower numbers for short.
ilonatommy Oct 5, 2023
6f2296e
Save issue in the comment.
ilonatommy Oct 5, 2023
5a451f0
Update values.
ilonatommy Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrame2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,12 +495,22 @@ await EvaluateOnCallFrameAndCheck(id,
("test.GetBoolNullable()", TBool(true)),
("test.GetNull()", TBool(true)),

("test.GetDefaultAndRequiredParam(2)", TNumber(5)),
("test.GetDefaultAndRequiredParam(3, 2)", TNumber(5)),
("test.GetDefaultAndRequiredParam(3, +2)", TNumber(5)),
("test.GetDefaultAndRequiredParam(3, -2)", TNumber(1)),
("test.GetDefaultAndRequiredParam(-123l, -1.1f)", TNumber("-124.1", isDecimal: true)), // long, float
("test.GetDefaultAndRequiredParam(-0.23)", TNumber("-32768.23", isDecimal: true)), // double, short
("test.SumDefaultAndRequiredParam(2)", TNumber(5)),
("test.SumDefaultAndRequiredParam(3, 2)", TNumber(5)),
("test.SumDefaultNegativeAndRequiredParamInts(3, +2)", TNumber(5)),
("test.SumDefaultNegativeAndRequiredParamInts(-3, -2)", TNumber(-5)),
("test.SumDefaultNegativeAndRequiredParamInts(-3)", TNumber(-6)), // default: -3
("test.SumDefaultNegativeAndRequiredParamLongInts(-1l, -2l)", TNumber(-3)),
("test.SumDefaultNegativeAndRequiredParamLongInts(-1l)", TNumber(-124)), // default: -123l
("test.SumDefaultNegativeAndRequiredParamFloats(-1.1f, -1.1f)", TNumber("-2.2", isDecimal: true)),
("test.SumDefaultNegativeAndRequiredParamFloats(-1.1f)", TNumber("-4.4", isDecimal: true)), // default: -3.3f
("test.SumDefaultNegativeAndRequiredParamDoubles(-0.1, -0.2)", TNumber("-0.30000000000000004", isDecimal: true)), // expected result for doubles copied from coreclr response
("test.SumDefaultNegativeAndRequiredParamDoubles(-0.1)", TNumber("-3.3000000000000003", isDecimal: true)), // default: -3.2
// https://github.com/dotnet/runtime/issues/93057
// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1, -120)", TNumber(-121)), // we have no way of testing it, debugger recognizes passed literals as integers and does not find the correct overload. We would need to cast to short and we don't support passing parameters with a cast.
// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1)", TNumber(-124)), // default: -123
// ("test.GetDefaultNegativeShortInt(-123)", TNumber(-123)),
("test.GetDefaultNegativeShortInt()", TNumber(-123)), // default: -123
("test.GetDefaultAndRequiredParamMixedTypes(\"a\")", TString("a; -1; False")),
("test.GetDefaultAndRequiredParamMixedTypes(\"a\", 23)", TString("a; 23; False")),
("test.GetDefaultAndRequiredParamMixedTypes(\"a\", 23, true)", TString("a; 23; True"))
Expand Down
10 changes: 7 additions & 3 deletions src/mono/wasm/debugger/tests/debugger-test/debugger-evaluate-test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,9 +1995,13 @@ public class TestClass
#nullable disable

public bool GetNull(object param = null) => param == null ? true : false;
public int GetDefaultAndRequiredParam(int requiredParam, int optionalParam = 3) => requiredParam + optionalParam;
public float GetDefaultAndRequiredParam(long requiredParam, float optionalParam = 3.3f) => requiredParam + optionalParam;
public double GetDefaultAndRequiredParam(double requiredParam, short optionalParam = -32768) => requiredParam + optionalParam;
public int SumDefaultAndRequiredParam(int requiredParam, int optionalParam = 3) => requiredParam + optionalParam;
public int SumDefaultNegativeAndRequiredParamInts(int requiredParam, int optionalParam = -3) => requiredParam + optionalParam;
public long SumDefaultNegativeAndRequiredParamLongInts(long requiredParam, long optionalParam = -123) => requiredParam + optionalParam;
public float SumDefaultNegativeAndRequiredParamFloats(float requiredParam, float optionalParam = -3.3f) => requiredParam + optionalParam;
public double SumDefaultNegativeAndRequiredParamDoubles(double requiredParam, double optionalParam = -3.2) => requiredParam + optionalParam;
public short SumDefaultNegativeAndRequiredParamShortInts(short requiredParam, short optionalParam = -123) => (short)(requiredParam + optionalParam);
public short GetDefaultNegativeShortInt(short optionalParam = -123) => optionalParam;
public string GetDefaultAndRequiredParamMixedTypes(string requiredParam, int optionalParamFirst = -1, bool optionalParamSecond = false) => $"{requiredParam}; {optionalParamFirst}; {optionalParamSecond}";
}

Expand Down