Skip to content

Lock that uses congestion detection for self-tuning #93879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VSadov wants to merge 6 commits into from
Closed

Lock that uses congestion detection for self-tuning #93879

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4431336
Use contention detection for self-tuning
VSadov Oct 23, 2023
2cd2fd6
small tweaks
VSadov Oct 29, 2023
164898e
more fine-grained spincount computation
VSadov Oct 31, 2023
eec1c81
backoff cleanup.
VSadov Nov 3, 2023
047a59c
use s_contentionCount as additional source of randomness
VSadov Nov 23, 2023
344ea2a
Update a comment.
VSadov Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update a comment.
  • Loading branch information
@VSadov
VSadov committed Dec 18, 2023
commit 344ea2a3b79db56f00e266b14e8e061d41ef5b16
18 changes: 9 additions & 9 deletions src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,19 +681,19 @@ private void LogContentionEnd(long contentionTrackingStartedTicks)
double waitDurationNs =
(Stopwatch.GetTimestamp() - contentionTrackingStartedTicks) * 1_000_000_000.0 / Stopwatch.Frequency;

// Also check NativeRuntimeEventSource.Log.IsEnabled() to enable trimming
if (NativeRuntimeEventSource.Log.IsEnabled())
try
{
try
// Also check NativeRuntimeEventSource.Log.IsEnabled() to enable trimming
if (NativeRuntimeEventSource.Log.IsEnabled())
{
NativeRuntimeEventSource.Log.ContentionStop(waitDurationNs);
}
catch
{
// We are throwing. The acquire failed.
this.Exit();
throw;
}
}
catch
{
// We are throwing. The acquire failed and we should not leave the lock locked.
this.Exit();
throw;
}
}

Expand Down