Add XUnitLogChecker to log libraries dumps #93906

carlossanlop · 2023-10-24T02:56:22Z

No description provided.

src/libraries/sendtohelixhelp.proj

src/native/external/brotli/dec/decode.c

ivdiazsa · 2023-10-25T18:43:43Z

The XUnitLogChecker enhancements work is going to be tracked here in issue #93988.

eng/pipelines/runtime.yml

eng/pipelines/libraries/helix.yml

src/libraries/sendtohelixhelp.proj

eng/testing/RunnerTemplate.sh

eng/testing/RunnerTemplate.cmd

eng/testing/RunnerTemplate.sh

src/libraries/sendtohelixhelp.proj

ghost · 2023-11-03T01:32:44Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-Infrastructure-libraries`
Milestone:	-

carlossanlop · 2023-11-14T17:35:32Z

Here are the remaining tasks for future PRs:

An error occurred trying to start process 'llvm-symbolizer' #91975 - example 1, example 2, Example 3
XUnitLogChecker: In OSX, no dumps are being found in the /cores directory #94720 - Example 1, Example 2
XUnitLogChecker: Frames are sometimes unresolved #94721 - Example 1, Example 2, Example 3
XUnitLogChecker: Enable for NativeAOT tests #94722
XUnitLogChecker: Consolidate duplicated properties in coreclr and libraries into one place #94802

ivdiazsa · 2023-11-14T17:39:44Z

All the remaining observations I had have already been pointed out in the review. So, it looks good to me now.

carlossanlop · 2023-11-14T17:44:20Z

@ViktorHofer I addressed your latest comment (remove unused envvar property defined outside of the condition). I only need a sign-off, and remove the temporary change that causes the crash and skips unrelated CIs, then I can merge if the CI is green in the final run.

hoyosjs

LGTM - minor q's

hoyosjs · 2023-11-14T18:00:48Z

Directory.Build.props

Do you need both in that case? Also, runtime flavor should remove a lot of the TargetOS ones.

eng/testing/RunnerTemplate.sh

src/libraries/sendtohelixhelp.proj

eng/testing/RunnerTemplate.sh

… special case Darwin

src/libraries/sendtohelixhelp.proj

eng/testing/RunnerTemplate.sh

jkotas · 2023-11-15T13:28:11Z

@carlossanlop This broke native AOT outer loop runs.

From https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/build/builds/470488/logs/135

error : Correlation Payload 'D:\a_work\1\s\artifacts\bin\XUnitLogChecker' not found. [D:\a_work\1\s\src\libraries\sendtohelixhelp.proj]

Could you please take a look asap?

carlossanlop · 2023-11-15T20:35:42Z

@jkotas apologies. I'll revert it, and then resubmit it but making sure I manually run outerloop too.

Here's the PR: #94807

This reverts commit d561f39.

…OT tests (#94868) * Add XUnitLogChecker to log libraries dumps (#93906) Libraries CI failures that generate dumps will now show the dump output in the console log itself. * Change NativeAOT condition * Pass the global property set to false in the post build step. * Address suggestion: - Avoid using yml extraHelixArguments. - Add the new embedded SetCommands optional section in runner scripts. - Set __IsXUnitLogCheckerSupported in tests.targets as SetScriptCommand items instead of directly in sendtohelixhelp.proj. * Only add XUnitLogChecker as HelixPayload if its directory is found. Whether it was built or not has already been decided before, and the runner scripts know when to execute it.

carlossanlop added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Oct 24, 2023

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 24, 2023

ghost assigned carlossanlop Oct 24, 2023

build-analysis bot mentioned this pull request Oct 24, 2023

LibraryImportGenerator unit test segfault illegal memory access #89054

Closed

ericstj reviewed Oct 24, 2023

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

ericstj reviewed Oct 24, 2023

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

carlossanlop changed the title ~~[Draft] Test~~ [Draft] Add XUnitLogChecker to log libraries dumps Oct 25, 2023

carlossanlop commented Oct 25, 2023

View reviewed changes

src/native/external/brotli/dec/decode.c Outdated Show resolved Hide resolved

carlossanlop removed the NO-REVIEW Experimental/testing PR, do NOT review it label Oct 25, 2023

build-analysis bot mentioned this pull request Oct 26, 2023

Test_EventSource_EtwManifestGeneration* tests failing in CI #48798

Closed

carlossanlop commented Oct 26, 2023

View reviewed changes

eng/pipelines/runtime.yml Outdated Show resolved Hide resolved

ericstj reviewed Oct 27, 2023

View reviewed changes

eng/pipelines/libraries/helix.yml Outdated Show resolved Hide resolved

This was referenced Oct 28, 2023

Timeout in System.Net.Quic.Functional.Tests #86019

Closed

CI error: System.Net.Quic.QuicException: The connection timed out from inactivity #91757

Closed

Test failure WindowsAlternateDataStreamOverwrite #83659

Open

ericstj reviewed Oct 31, 2023

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Nov 1, 2023

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests #92467

Closed

ericstj reviewed Nov 1, 2023

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

carlossanlop commented Nov 2, 2023

View reviewed changes

eng/testing/RunnerTemplate.sh Outdated Show resolved Hide resolved

carlossanlop commented Nov 2, 2023

View reviewed changes

eng/testing/RunnerTemplate.sh Outdated Show resolved Hide resolved

carlossanlop removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 2, 2023

carlossanlop changed the title ~~[Draft] Add XUnitLogChecker to log libraries dumps~~ Add XUnitLogChecker to log libraries dumps Nov 2, 2023

ericstj reviewed Nov 2, 2023

View reviewed changes

eng/testing/RunnerTemplate.sh Outdated Show resolved Hide resolved

eng/testing/RunnerTemplate.cmd Outdated Show resolved Hide resolved

eng/testing/RunnerTemplate.cmd Outdated Show resolved Hide resolved

eng/testing/RunnerTemplate.sh Outdated Show resolved Hide resolved

ViktorHofer reviewed Nov 2, 2023

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

carlossanlop marked this pull request as ready for review November 3, 2023 01:32

carlossanlop added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 3, 2023

carlossanlop mentioned this pull request Nov 14, 2023

XUnitLogChecker: In OSX, no dumps are being found in the /cores directory #94720

Open

This was referenced Nov 14, 2023

XUnitLogChecker: Frames are sometimes unresolved #94721

Closed

XUnitLogChecker: Enable for NativeAOT tests #94722

Open

hoyosjs approved these changes Nov 14, 2023

View reviewed changes

carlossanlop commented Nov 14, 2023

View reviewed changes

eng/testing/RunnerTemplate.sh Outdated Show resolved Hide resolved

In OSX, $HELIX_DUMP_FOLDER is passed as /cores, so we don't need to…

3686646

… special case Darwin

carlossanlop commented Nov 14, 2023

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

carlossanlop added 2 commits November 14, 2023 13:44

Missed a ;

87f7055

Another missed ;

3da51fb

carlossanlop commented Nov 14, 2023

View reviewed changes

eng/testing/RunnerTemplate.sh Outdated Show resolved Hide resolved

Use the $core_file_name when renaming the dmp

0d15bf8

carlossanlop commented Nov 14, 2023

View reviewed changes

eng/testing/RunnerTemplate.sh Outdated Show resolved Hide resolved

carlossanlop added 3 commits November 14, 2023 13:49

Remove sleep

bcd2acf

Remove $RANDOM

7857f36

Revert the temporary crash and the disabled CI legs.

fab3449

carlossanlop removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 15, 2023

carlossanlop mentioned this pull request Nov 15, 2023

pip fails to build wheels for cffi (gcc not found) in ubuntu.1804.armarch.open using image alpine-3.15-helix-arm32v7 dotnet/dnceng#1423

Closed

3 tasks

carlossanlop merged commit d561f39 into dotnet:main Nov 15, 2023

carlossanlop deleted the LibrariesXUnitLogChecker branch November 15, 2023 04:09

carlossanlop added a commit that referenced this pull request Nov 15, 2023

Revert "Add XUnitLogChecker to log libraries dumps (#93906)"

87f4adf

This reverts commit d561f39.

carlossanlop mentioned this pull request Nov 15, 2023

Revert "Add XUnitLogChecker to log libraries dumps" #94807

Merged

carlossanlop added a commit that referenced this pull request Nov 15, 2023

Revert "Add XUnitLogChecker to log libraries dumps (#93906)" (#94807)

e58f897

This reverts commit d561f39.

carlossanlop mentioned this pull request Nov 16, 2023

Add XUnitLogChecker to log libraries dumps, do not enable for NativeAOT tests #94868

Merged

github-actions bot locked and limited conversation to collaborators Dec 17, 2023

Add XUnitLogChecker to log libraries dumps #93906

Add XUnitLogChecker to log libraries dumps #93906

Uh oh!

Conversation

carlossanlop commented Oct 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivdiazsa commented Oct 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Nov 3, 2023

Uh oh!

carlossanlop commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivdiazsa commented Nov 14, 2023

Uh oh!

carlossanlop commented Nov 14, 2023

Uh oh!

hoyosjs left a comment

Choose a reason for hiding this comment

Uh oh!

hoyosjs Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlossanlop commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

carlossanlop commented Nov 14, 2023 •

edited

Loading

jkotas commented Nov 15, 2023 •

edited

Loading

carlossanlop commented Nov 15, 2023 •

edited

Loading