Skip to content

[mono] Simplify of OffsetToStringData as it's done on coreclr #93987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 7 commits into from
Oct 26, 2023
Merged

[mono] Simplify of OffsetToStringData as it's done on coreclr #93987

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1553f0
Change implementation of OffsetToStringData as it's done on coreclr
thaystg Oct 25, 2023
ac114c4
Fix comment
thaystg Oct 25, 2023
385991b
Remove more comments
thaystg Oct 25, 2023
9f52da8
completely remove the comments
thaystg Oct 25, 2023
f6a1028
Update RuntimeHelpers.Mono.cs
thaystg Oct 25, 2023
b94d307
Addressing comments
thaystg Oct 26, 2023
9695c42
Addressing @lambdageek comment.
thaystg Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove more comments
  • Loading branch information
@thaystg
thaystg authored Oct 25, 2023
commit 385991b98fca25510475cb3b50a1bb969aae643a
5 changes: 0 additions & 5 deletions src/mono/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.Mono.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ public static int OffsetToStringData
{
[NonVersionable]
get =>
// Number of bytes from the address pointed to by a reference to
// a String to the first 16-bit character in the String. Skip
// over the MethodTable pointer, & String
// length. Of course, the String reference points to the memory
// after the sync block, so don't count that.
// This property allows C#'s fixed statement to work on Strings.
// On 64 bit platforms, this should be 20 and on 32 bit 12.
#if TARGET_64BIT
Expand Down