Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix merge conflict
  • Loading branch information
amanasifkhalid committed Nov 28, 2023
commit 722f16a6ced20490b32805f8b9796bc6d79f8fdc
4 changes: 2 additions & 2 deletions src/coreclr/jit/fgbasic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5537,8 +5537,8 @@ BasicBlock* Compiler::fgConnectFallThrough(BasicBlock* bSrc, BasicBlock* bDst)
break;
}
}
else if (bSrc->KindIs(BBJ_ALWAYS) && ((bSrc->bbFlags & BBF_KEEP_BBJ_ALWAYS) == 0) && bSrc->HasJump() &&
bSrc->JumpsToNext())
else if (bSrc->KindIs(BBJ_ALWAYS) && ((bSrc->bbFlags & BBF_KEEP_BBJ_ALWAYS) == 0) &&
bSrc->HasInitializedJumpDest() && bSrc->JumpsToNext())
{
bSrc->bbFlags |= BBF_NONE_QUIRK;
}
Expand Down
5 changes: 3 additions & 2 deletions src/coreclr/jit/fgehopt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,8 @@ PhaseStatus Compiler::fgCloneFinally()
newBlock->clearHndIndex();

// Jump dests are set in a post-pass; make sure CloneBlockState hasn't tried to set them.
assert(newBlock->KindIs(BBJ_NONE));
assert(newBlock->KindIs(BBJ_ALWAYS));
assert(!newBlock->HasInitializedJumpDest());
}

if (!clonedOk)
Expand All @@ -1101,7 +1102,7 @@ PhaseStatus Compiler::fgCloneFinally()
BasicBlock* newBlock = blockMap[block];
// Jump kind/target should not be set yet
assert(newBlock->KindIs(BBJ_ALWAYS));
assert(!newBlock->HasJump());
assert(!newBlock->HasInitializedJumpDest());

if (block->KindIs(BBJ_EHFINALLYRET))
{
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/jit/loopcloning.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2191,7 +2191,7 @@ void Compiler::optCloneLoop(unsigned loopInd, LoopCloneContext* context)
assert(b && newblk != nullptr);

// Jump target should not be set yet
assert(!newblk->HasJump());
assert(!newblk->HasInitializedJumpDest());

// First copy the jump destination(s) from "blk".
optCopyBlkDest(blk, newblk);
Expand Down Expand Up @@ -2265,7 +2265,7 @@ void Compiler::optCloneLoop(unsigned loopInd, LoopCloneContext* context)

// We haven't set the jump target yet
assert(slowHead->KindIs(BBJ_ALWAYS));
assert(!slowHead->HasJump());
assert(!slowHead->HasInitializedJumpDest());
slowHead->SetJumpDest(e2);

fgAddRefPred(e2, slowHead);
Expand Down
9 changes: 5 additions & 4 deletions src/coreclr/jit/optimizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4394,7 +4394,8 @@ PhaseStatus Compiler::optUnrollLoops()
newBlock->scaleBBWeight(1.0 / BB_LOOP_WEIGHT_SCALE);

// Jump dests are set in a post-pass; make sure CloneBlockState hasn't tried to set them.
assert(newBlock->KindIs(BBJ_NONE));
assert(newBlock->KindIs(BBJ_ALWAYS));
assert(!newBlock->HasInitializedJumpDest());

if (block == bottom)
{
Expand Down Expand Up @@ -4423,7 +4424,7 @@ PhaseStatus Compiler::optUnrollLoops()
{
// Jump kind/target should not be set yet
BasicBlock* newBlock = blockMap[block];
assert(!newBlock->HasJump());
assert(!newBlock->HasInitializedJumpDest());

// Now copy the jump kind/target
optCopyBlkDest(block, newBlock);
Expand All @@ -4440,7 +4441,7 @@ PhaseStatus Compiler::optUnrollLoops()

if (clonedTopPrev->KindIs(BBJ_ALWAYS))
{
assert(!clonedTopPrev->HasJump());
assert(!clonedTopPrev->HasInitializedJumpDest());
clonedTopPrev->SetJumpDest(clonedTop);
}

Expand Down Expand Up @@ -4571,7 +4572,7 @@ PhaseStatus Compiler::optUnrollLoops()
{
BasicBlock* clonedBottom = blockMap[bottom];
assert(clonedBottom->KindIs(BBJ_ALWAYS));
assert(!clonedBottom->HasJump());
assert(!clonedBottom->HasInitializedJumpDest());

clonedBottom->SetJumpDest(tail);
fgAddRefPred(tail, clonedBottom);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.