-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0-staging] Socket Tests Disable #94243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Socket Tests Disable #94243
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsRelated #94149.
|
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all the formatting changes? Is this a packport of a PR against main that also introduces them? If no, it's better to undo them to reduce chances for conflicts in future backports.
I was just trying something out, if my changes were causing the formatting failures etc but it wasn't I saw the same problem on release/8.0-staging branch as well. |
This reverts commit 6ee1383.
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
CI failures are unrelated:
This is test-only change (disabling tests) to work around Linux Kernel regression. |
|
@artl93 @carlossanlop this is test-only, can we just flip it to Servicing-approved? Or what is the process? |
|
Yes, test-only changes are tell-mode, they can be marked as servicing approved directly. |
|
in case the change was approved via email: should we also flip the tag and merge it to staging ... or ... should we wait .... or something else ???? |
|
I already added the servicing approved label. Area owners are free to merge whenever they're ready, once the CI looks good and it has been signed-off. For future reference, you can consult the library servicing doc where the process is explained: https://github.com/dotnet/runtime/blob/release/8.0/docs/project/library-servicing.md |
|
/backport to release/7.0-staging |
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/6815234007 |
|
/backport to release/6.0-staging |
|
Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/6815556950 |
|
@liveans backporting to release/6.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Linux Kernel Regression Socket Test Failures Disable
.git/rebase-apply/patch:19: trailing whitespace.
.git/rebase-apply/patch:36: trailing whitespace.
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
M src/libraries/System.Net.Sockets/tests/FunctionalTests/TelemetryTest.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Sockets/tests/FunctionalTests/TelemetryTest.cs
Auto-merging src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
CONFLICT (content): Merge conflict in src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Linux Kernel Regression Socket Test Failures Disable
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@liveans an error occurred while backporting to release/6.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Related to #94149
Test-only change to decrease CI noise.
Disabling tests which started failing due to Linux Kernel regression (tracked by #94149):