Skip to content

Conversation

@liveans
Copy link
Member

@liveans liveans commented Oct 31, 2023

Related to #94149

Test-only change to decrease CI noise.

Disabling tests which started failing due to Linux Kernel regression (tracked by #94149):

  • System.Net.Sockets.Tests.ConnectSync.ConnectGetsCanceledByDispose
  • System.Net.Sockets.Tests.TelemetryTest.EventSource_SocketConnectFailure_LogsConnectFailed

@ghost ghost assigned liveans Oct 31, 2023
@ghost
Copy link

ghost commented Oct 31, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Related #94149.
We're disabling those tests until they're fixed to decrease CI noise.

Author: liveans
Assignees: liveans
Labels:

area-System.Net.Sockets

Milestone: -

@liveans liveans requested a review from a team October 31, 2023 21:26
@liveans
Copy link
Member Author

liveans commented Oct 31, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karelz karelz added this to the 8.0.x milestone Nov 1, 2023
@karelz karelz added the test-bug Problem in test source code (most likely) label Nov 1, 2023
@liveans
Copy link
Member Author

liveans commented Nov 1, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Nov 3, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Nov 6, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all the formatting changes? Is this a packport of a PR against main that also introduces them? If no, it's better to undo them to reduce chances for conflicts in future backports.

@liveans
Copy link
Member Author

liveans commented Nov 6, 2023

Why all the formatting changes? Is this a packport of a PR against main that also introduces them? If no, it's better to undo them to reduce chances for conflicts in future backports.

I was just trying something out, if my changes were causing the formatting failures etc but it wasn't I saw the same problem on release/8.0-staging branch as well.

@liveans
Copy link
Member Author

liveans commented Nov 6, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karelz
Copy link
Member

karelz commented Nov 7, 2023

CI failures are unrelated:

  • 2x Build Formatting windows x64 -- Format job found errors, please apply the format patch.

This is test-only change (disabling tests) to work around Linux Kernel regression.
@artl93 FYI - adding label Servicing-consider

@karelz karelz added the Servicing-consider Issue for next servicing release review label Nov 7, 2023
@karelz
Copy link
Member

karelz commented Nov 9, 2023

@artl93 @carlossanlop this is test-only, can we just flip it to Servicing-approved? Or what is the process?

@carlossanlop
Copy link
Contributor

Yes, test-only changes are tell-mode, they can be marked as servicing approved directly.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 9, 2023
@wfurt
Copy link
Member

wfurt commented Nov 9, 2023

in case the change was approved via email: should we also flip the tag and merge it to staging ... or ... should we wait .... or something else ????

@carlossanlop
Copy link
Contributor

I already added the servicing approved label. Area owners are free to merge whenever they're ready, once the CI looks good and it has been signed-off.

For future reference, you can consult the library servicing doc where the process is explained: https://github.com/dotnet/runtime/blob/release/8.0/docs/project/library-servicing.md

@liveans liveans merged commit 87fbb38 into dotnet:release/8.0-staging Nov 9, 2023
@liveans
Copy link
Member Author

liveans commented Nov 9, 2023

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/6815234007

@liveans
Copy link
Member Author

liveans commented Nov 9, 2023

/backport to release/6.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/6815556950

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

@liveans backporting to release/6.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Linux Kernel Regression Socket Test Failures Disable
.git/rebase-apply/patch:19: trailing whitespace.
            
.git/rebase-apply/patch:36: trailing whitespace.
            
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
M	src/libraries/System.Net.Sockets/tests/FunctionalTests/TelemetryTest.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Sockets/tests/FunctionalTests/TelemetryTest.cs
Auto-merging src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
CONFLICT (content): Merge conflict in src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Linux Kernel Regression Socket Test Failures Disable
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

@liveans an error occurred while backporting to release/6.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@carlossanlop carlossanlop modified the milestones: 8.0.x, 8.0.1 Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net.Sockets Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants