-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Expose ChannelReader.ReadAllAsync from non-core builds as well #94417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure why we didn't fix this before when we shipped Microsoft.Bcl.AsyncInterfaces, but with IAsyncEnumerable available downlevel, there's no need to hide this method away; it can be in all builds. Doing so makes it easier for others to create their own channel implementations, as they don't _need_ to multitarget in order to override everything they might want to. I've not changed any C# code, just moved it between files.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-threading-channels Issue DetailsI'm not sure why we didn't fix this before when we shipped Microsoft.Bcl.AsyncInterfaces, but with IAsyncEnumerable available downlevel, there's no need to hide this method away; it can be in all builds. Doing so makes it easier for others to create their own channel implementations, as they don't need to multitarget in order to override everything they might want to. I've not changed any C# code, just moved it between files.
|
src/libraries/System.Threading.Channels/ref/System.Threading.Channels.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.Channels/tests/System.Threading.Channels.Tests.csproj
Outdated
Show resolved
Hide resolved
|
Thanks, @ViktorHofer. Fixed. |
I'm not sure why we didn't fix this before when we shipped Microsoft.Bcl.AsyncInterfaces, but with IAsyncEnumerable available downlevel, there's no need to hide this method away; it can be in all builds. Doing so makes it easier for others to create their own channel implementations, as they don't need to multitarget in order to override everything they might want to.
I've not changed any C# code, just moved it between files.