[release/8.0] Calculate PackageVersionNet7 #94614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 8.0 is GA, we'll be able to calculate the net7 version based on PatchVersion
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsSince 8.0 is GA, we'll be able to calculate the net7 version based on PatchVersion
|
Member
Author
|
@carlossanlop this is an infra only change. |
Contributor
radical
approved these changes
Nov 14, 2023
lewing
approved these changes
Nov 14, 2023
| <PatchVersion>0</PatchVersion> | ||
| <SdkBandVersion>8.0.100</SdkBandVersion> | ||
| <PackageVersionNet7>7.0.12</PackageVersionNet7> | ||
| <PackageVersionNet7>7.0.$([MSBuild]::Add($(PatchVersion),14))</PackageVersionNet7> |
Member
There was a problem hiding this comment.
If we do not ship 6 and 7 along side 8 in the next release this will need to change
Suggested change
| <PackageVersionNet7>7.0.$([MSBuild]::Add($(PatchVersion),14))</PackageVersionNet7> | |
| <PackageVersionNet7>7.0.$([MSBuild]::Add($(PatchVersion),13))</PackageVersionNet7> |
Contributor
|
@steveisok can you please take a look at the feedback? Today's code complete. |
Member
Author
|
We should merge this and follow up if necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8.0 is GA, we'll be able to calculate the net7 version based on PatchVersion