Skip to content

[wasm] Enable WasmStripILAfterAOT by default #94682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fanyang-mono merged 1 commit into from
Nov 14, 2023
+6 −6
Merged

[wasm] Enable WasmStripILAfterAOT by default #94682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ void AssertResourcesDlls(string basePath)
}

[Theory]
[InlineData("", false)] // Default case
[InlineData("true", true)] // the other case
[InlineData("", true)] // Default case
[InlineData("false", false)] // the other case
public async Task Test_WasmStripILAfterAOT(string stripILAfterAOT, bool expectILStripping)
{
string config = "Release";
Expand Down
4 changes: 2 additions & 2 deletions src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,8 +493,8 @@ public void BuildAndRunForDifferentOutputPaths(string config, bool appendRID, bo
}

[Theory]
[InlineData("", false)] // Default case
[InlineData("true", true)] // the other case
[InlineData("", true)] // Default case
[InlineData("false", false)] // the other case
public void Test_WasmStripILAfterAOT(string stripILAfterAOT, bool expectILStripping)
{
string config = "Release";
Expand Down
4 changes: 2 additions & 2 deletions src/mono/wasm/build/WasmApp.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
- AppBundle/_framework contains generated files (dlls, runtime scripts, icu)
- AppBundle/_content contains web files from nuget packages (css, js, etc)
- $(WasmStripILAfterAOT) - Set to true to enable trimming away AOT compiled methods body (IL code)
Defaults to false.
Defaults to true.

Public items:
- @(WasmExtraFilesToDeploy) - Files to copy to $(WasmAppDir).
Expand Down Expand Up @@ -150,7 +150,7 @@
<WasmAssemblyExtension Condition="'$(WasmEnableWebcil)' == 'true'">.wasm</WasmAssemblyExtension>
<WasmAssemblyExtension Condition="'$(WasmEnableWebcil)' != 'true'">.dll</WasmAssemblyExtension>

<WasmStripILAfterAOT Condition="'$(WasmStripILAfterAOT)' == ''">false</WasmStripILAfterAOT>
<WasmStripILAfterAOT Condition="'$(WasmStripILAfterAOT)' == ''">true</WasmStripILAfterAOT>

<WasmRuntimeAssetsLocation Condition="'$(WasmRuntimeAssetsLocation)' == ''">_framework</WasmRuntimeAssetsLocation>
</PropertyGroup>
Expand Down