[release/8.0-staging] #ifdef out code that requires FEATURE_EVENT_TRACE #94715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #91895 to release/8.0-staging Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jkotas
approved these changes
Nov 14, 2023
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Nov 14, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
Contributor
|
@jkotas @jeffschwMSFT did this get Tactics approval? Today's code complete. |
jeffschwMSFT
added
Servicing-approved
Member
Yes, this was approved over email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91895 to release/8.0-staging
/cc @jkotas @yowl
Customer Impact
Build break when building a custom runtime configuration with disabled tracing from sources. This configuration is used by game console ports. Regression from .NET 7.
Testing
Local build of the custom configuration.
Risk
Low. The change is no-op for the default shipping configuration.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.