Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 14, 2023

Backport of #94710 to release/8.0-staging

/cc @steveisok @Saratsin

Customer Impact

Developers targeting Android encountered ThrowOverflowOrFormatException when using DateTimeOffset.Now for cultures where negative numbers have the - symbol appended rather than prepended. (e.g. 2000- in arabic culture).

Testing

Local testing

Risk

Low. The change enables DateTimeOffset.Now on Android to parse the time obtained from Java APIs in a culture-independent manner.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Fixed issue when DateTimeOffset.Now throws exception on Android with Arabic language & western hemisphere timezone
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 14, 2023
@steveisok steveisok added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 14, 2023
@ghost
Copy link

ghost commented Nov 14, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #94710 to release/8.0-staging

/cc @steveisok @Saratsin

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.DateTime, needs-area-label

Milestone: -

@steveisok steveisok added Servicing-consider Issue for next servicing release review os-android labels Nov 14, 2023
@ghost
Copy link

ghost commented Nov 14, 2023

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #94710 to release/8.0-staging

/cc @steveisok @Saratsin

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, os-android, area-System.DateTime

Milestone: -

@lambdageek lambdageek added this to the 8.0.x milestone Nov 15, 2023
@carlossanlop
Copy link
Contributor

@steveisok @akoeplinger @lambdageek did this get Tactics approval? Today is code complete.

@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 15, 2023
@steveisok steveisok merged commit 467099f into release/8.0-staging Nov 15, 2023
@steveisok steveisok deleted the backport/pr-94710-to-release/8.0-staging branch November 15, 2023 21:43
@carlossanlop carlossanlop modified the milestones: 8.0.x, 8.0.1 Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants