Skip to content

Add ConstructorBuilder implementation, integrate TypeBuilder.GetXyz() static methods #94732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buyaa-n merged 13 commits into from
Nov 18, 2023
Merged

Add ConstructorBuilder implementation, integrate TypeBuilder.GetXyz() static methods #94732

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
005aa2d
Add initial ConstructorBuilder implementation
buyaa-n Apr 24, 2023
2b7c2ff
Merge conflicts
buyaa-n Nov 6, 2023
49e4b89
Integrate TypeBuilder.GetConstructor/GetField/GetMethod implementatio…
buyaa-n Nov 8, 2023
9ee9a02
Add implementation for GetConstructorImpl
buyaa-n Nov 11, 2023
93bb956
Remove TypeBuilderInstantiation reference, emit TypeSpecification for…
buyaa-n Nov 14, 2023
9b67fb1
Merge conflicts
buyaa-n Nov 14, 2023
bdd381a
Fix bad merging
buyaa-n Nov 14, 2023
839cf8a
Include ***Instantiations on AOT build, throw for baked non baked typ…
buyaa-n Nov 15, 2023
836fef4
Set type and its members tokens on CreateTypeInfoCore
buyaa-n Nov 16, 2023
cca300a
Implement MethodBuilder.GetParameters() using a ParameterInfoWrapper
buyaa-n Nov 16, 2023
502bd66
Merge conflicts
buyaa-n Nov 16, 2023
ffd43b6
Apply feedbacks, add method specification handling for constructed me…
buyaa-n Nov 17, 2023
b08148c
Apply feedback
buyaa-n Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge conflicts
  • Loading branch information
@buyaa-n
buyaa-n committed Nov 6, 2023
commit 2b7c2ff0d498950a1aa0a0f1fcd734592df18a5d
12 changes: 12 additions & 0 deletions src/libraries/System.Reflection.Emit/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,16 @@
<data name="InvalidOperation_ConstructorNotAllowedOnInterface" xml:space="preserve">
<value>Interface cannot have constructors.</value>
</data>
<data name="Argument_UnmatchedMethodForLocal" xml:space="preserve">
<value>Local passed in does not belong to this ILGenerator.</value>
</data>
<data name="Argument_InvalidLabel" xml:space="preserve">
<value>Invalid Label.</value>
</data>
<data name="Argument_MustBeSwitchOpCode" xml:space="preserve">
<value>Only 'OpCode.Switch' can be used.</value>
</data>
<data name="Argument_NotMethodCallOpcode" xml:space="preserve">
<value>The specified opcode cannot be passed to EmitCall.</value>
</data>
</root>
You are viewing a condensed version of this merge commit. You can view the full changes here.