Skip to content

[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 8 commits into from
Nov 22, 2023
Merged

[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0aa0480
Fix JsonArray.Add and ReplaceWith regressions.
eiriktsarpalis Nov 16, 2023
cc4957f
Add comment
eiriktsarpalis Nov 16, 2023
c64df0f
Address feedback.
eiriktsarpalis Nov 16, 2023
650582e
Update packaging metadata
eiriktsarpalis Nov 17, 2023
58cf1cb
Bring back removed using statement
eiriktsarpalis Nov 17, 2023
b00d045
Fix the build error that was showing up after bumping the ServicingVe…
carlossanlop Nov 22, 2023
3656e7d
Update src/libraries/System.Text.Json/tests/System.Text.Json.SourceGe…
ViktorHofer Nov 22, 2023
9500afa
Fix incremental servicing props ordering issue
ViktorHofer Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis authored and github-actions committed Nov 16, 2023
commit cc4957fd643ac4ed3d0f3992eb5e86af94364bd1
5 changes: 5 additions & 0 deletions src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,11 @@ internal void AssignParent(JsonNode parent)
Parent = parent;
}

/// <summary>
/// Adaptation of the equivalent JsonValue.Create factory method extended
/// to support arbitrary <see cref="JsonElement"/> and <see cref="JsonNode"/> values.
/// TODO consider making public cf. https://github.com/dotnet/runtime/issues/70427
/// </summary>
[RequiresUnreferencedCode(JsonSerializer.SerializationUnreferencedCodeMessage)]
[RequiresDynamicCode(JsonSerializer.SerializationRequiresDynamicCodeMessage)]
internal static JsonNode? ConvertFromValue<T>(T? value, JsonNodeOptions? options = null)
Expand Down