Skip to content

[release/8.0-staging] Add JSON null support for the built-in (ReadOnly)Memory converters. #95325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Nov 30, 2023
Merged

[release/8.0-staging] Add JSON null support for the built-in (ReadOnly)Memory converters. #95325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76d816
Add JSON null support for the built-in (ReadOnly)Memory converters.
eiriktsarpalis Nov 27, 2023
dec0060
Address feedback
eiriktsarpalis Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address feedback
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis authored and github-actions committed Nov 28, 2023
commit dec00601605cc5f679109332392e5aa1e125b283
2 changes: 1 addition & 1 deletion ...tem.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/MemoryConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal override bool OnTryRead(
Type typeToConvert,
JsonSerializerOptions options,
scoped ref ReadStack state,
[MaybeNullWhen(false)] out Memory<T> value)
out Memory<T> value)
{
if (reader.TokenType is JsonTokenType.Null)
{
Expand Down
2 changes: 1 addition & 1 deletion ....Json/src/System/Text/Json/Serialization/Converters/Collection/ReadOnlyMemoryConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal override bool OnTryRead(
Type typeToConvert,
JsonSerializerOptions options,
scoped ref ReadStack state,
[MaybeNullWhen(false)] out ReadOnlyMemory<T> value)
out ReadOnlyMemory<T> value)
{
if (reader.TokenType is JsonTokenType.Null)
{
Expand Down