Fix FormatException message argument #95356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-datetime |
Member
Author
|
@stephentoub I've attempted to minimize the fix here for servicing purposes. Additionally, I've reviewed the remaining failure cases and confirmed that they are handling the situation appropriately. |
Member
Author
artl93
approved these changes
Nov 29, 2023
tarekgh
added
Servicing-consider
Member
Author
|
approved offline. |
ericstj
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95331
#82947
Customer Impact
When encountering a failure in parsing a date string, the exception message will lack a crucial section containing the original date string being parsed. This omission complicates the diagnosis of the failure, making it challenging to discern the underlying reason. This issue has surfaced as a recent regression in .NET 8.0 and has been reported three times within a short period.
Testing
Passed the regression tests and added more tests to cover the failing cases.
Risk
Low, the modification solely impacts the parameter of the exception message and does not alter any other aspects of the logic