ServiceKey comparisons use Equals for matching

[tommysor]

Fix #95754

I assume here that the issue (currently untriaged) is confirmed as a bug.

Based on documentation: https://learn.microsoft.com/en-us/dotnet/core/extensions/dependency-injection#keyed-services

The key isn't limited to string, it can be any object you want, as long as the type correctly implements Equals.

Also based on comparison for resolving in ServiceProvider.GetRequiredKeyedService.
That is implemented in Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceIdentifier

public bool Equals(ServiceIdentifier other)
{
	if (ServiceKey == null && other.ServiceKey == null)
	{
		return ServiceType == other.ServiceType;
	}
	else if (ServiceKey != null && other.ServiceKey != null)
	{
		return ServiceType == other.ServiceType && ServiceKey.Equals(other.ServiceKey);
	}
	return false;
}

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fix #95754

I assume here that the issue (currently untriaged) is confirmed as a bug.

Based on documentation: https://learn.microsoft.com/en-us/dotnet/core/extensions/dependency-injection#keyed-services

The key isn't limited to string, it can be any object you want, as long as the type correctly implements Equals.

Also based on comparison for resolving in ServiceProvider.GetRequiredKeyedService.
That is implemented in Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceIdentifier

public bool Equals(ServiceIdentifier other)
{
	if (ServiceKey == null && other.ServiceKey == null)
	{
		return ServiceType == other.ServiceType;
	}
	else if (ServiceKey != null && other.ServiceKey != null)
	{
		return ServiceType == other.ServiceType && ServiceKey.Equals(other.ServiceKey);
	}
	return false;
}

Author:	tommysor
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[halter73]

Thank you! This looks like a simple fix to the keyed TryAddEnumerable/Remove/Replace service collection extensions. Thanks for added the regression tests too.

I think we should backport this for .NET 8 patching.

[ericstj]

/azp run

[azure-pipelines]

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

[ericstj]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[steveharter]

/backport to release/8.0-staging

[github-actions]

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7491216853