Revert "Build tests as self-contained for native AOT" #95880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ee1abba.
ghost
added
the
needs-area-label
Member
Author
|
#95881 needs to go in first. |
MichalStrehovsky
added
the
NO-MERGE
Member
|
Is this needed at all? Seems like less to revert if we leave it as is and fix the sdk tests? |
teo-tsirpanis
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsReverts #95718 This is blocking SDK integration: dotnet/sdk#37350. I tried fixing the test failures (that are due to every single test doing We don't really need erroring out that much. Ideally SDK owners will make
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #95718
This is blocking SDK integration: dotnet/sdk#37350. I tried fixing the test failures (that are due to every single test doing
t:Publish), but there are still failures and the logs are useless and offer no way to corelate failures to a single test.We don't really need erroring out that much. Ideally SDK owners will make
/t:Publishto not be weird.